linux-kernel - Re: [PATCH v2] prctl: Deprecate non PR_SET_MM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180405195156.GN15783@uranus.lan>
Date:   Thu, 5 Apr 2018 22:51:56 +0300
From:   Cyrill Gorcunov <gorcunov@...il.com>
To:     Michal Hocko <mhocko@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Andrey Vagin <avagin@...nvz.org>,
        Andrew Morton <akpm@...uxfoundation.org>,
        Pavel Emelyanov <xemul@...tuozzo.com>,
        Michael Kerrisk <mtk.manpages@...il.com>,
        Yang Shi <yang.shi@...ux.alibaba.com>
Subject: Re: [PATCH v2] prctl: Deprecate non PR_SET_MM_MAP operations

On Thu, Apr 05, 2018 at 08:56:50PM +0200, Michal Hocko wrote:
> On Thu 05-04-18 21:26:51, Cyrill Gorcunov wrote:
> > An ability to manipulate mm_struct fields was introduced in
> > sake of CRIU in first place. Later we provide more suitable
> > and safe operation PR_SET_MM_MAP where all fields to be modifed
> > are passed in one structure which allows us to make more detailed
> > verification.
> 
> I hope this will serve as a memento for future single-user APIs
> proposals. The whole thing was a bad idea since the beginning.

It wasn't a bad idea at all, kernel evolves with time and the
first version of the api served as it should (actually a number
of things get involved like user-namespaces, mm reworks and
such things). So no, it wasn't bad. Rather to make it more
suitable we provided a second version of the api.

> > Still old interface remains present for compatibility reason
> > though CRIU itself already switched to PR_SET_MM_MAP on its
> > own long ago.
> > 
> > Googling didn't reveal some other users of this operation
> > so I think it should be safe to remove this interface.
> > 
> > v2:
> >  - Improve warning message
> >  - Drop redundant args check
> > 
> > CC: Andrey Vagin <avagin@...nvz.org>
> > CC: Andrew Morton <akpm@...uxfoundation.org>
> > CC: Pavel Emelyanov <xemul@...tuozzo.com>
> > CC: Michael Kerrisk <mtk.manpages@...il.com>
> > CC: Yang Shi <yang.shi@...ux.alibaba.com>
> > CC: Michal Hocko <mhocko@...nel.org>
> > Signed-off-by: Cyrill Gorcunov <gorcunov@...il.com>
> 
> Acked-by: Michal Hocko <mhocko@...e.com>
> 
> and fingers crossed that we haven't grown other users outside of CRIU
> which is quite bound to specific kernels AFAIK.

Surely.