linux-kernel - RE: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector blacklist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW2PR2101MB1113040CF411696D9674B6D6A0BB0@MW2PR2101MB1113.namprd21.prod.outlook.com>
Date:   Thu, 5 Apr 2018 19:52:32 +0000
From:   KY Srinivasan <kys@...rosoft.com>
To:     Ross Lagerwall <ross.lagerwall@...rix.com>,
        Long Li <longli@...rosoft.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Matt Kurjanowicz <mattkur@...rosoft.com>
CC:     "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector
 blacklist

+Matt

> -----Original Message-----
> From: Ross Lagerwall <ross.lagerwall@...rix.com>
> Sent: Thursday, April 5, 2018 9:58 AM
> To: Long Li <longli@...rosoft.com>; Martin K. Petersen
> <martin.petersen@...cle.com>; KY Srinivasan <kys@...rosoft.com>
> Cc: James E.J. Bottomley <jejb@...ux.vnet.ibm.com>; linux-
> scsi@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024 sector
> blacklist
> 
> On 03/28/2018 11:33 PM, Long Li wrote:
> >> Subject: Re: [PATCH] scsi: devinfo: Add Microsoft iSCSI target to 1024
> sector
> >> blacklist
> >>
> >>
> >> Long, KY: Please confirm.
> >>
> >>> The Windows Server 2016 iSCSI target doesn't work with the Linux
> >>> kernel initiator since the kernel started sending larger requests by
> >>> default, nor does it implement the block limits VPD page. Apply the
> >>> sector limit workaround for these targets.
> >>>
> >>> Signed-off-by: Ross Lagerwall <ross.lagerwall@...rix.com>
> >>> ---
> >>>   drivers/scsi/scsi_devinfo.c | 2 +-
> >>>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
> >>> index f3b1172..5cb748a 100644
> >>> --- a/drivers/scsi/scsi_devinfo.c
> >>> +++ b/drivers/scsi/scsi_devinfo.c
> >>> @@ -213,7 +213,7 @@ static struct {
> >>>   	{"Medion", "Flash XL  MMC/SD", "2.6D", BLIST_FORCELUN},
> >>>   	{"MegaRAID", "LD", NULL, BLIST_FORCELUN},
> >>>   	{"MICROP", "4110", NULL, BLIST_NOTQ},
> >>> -	{"MSFT", "Virtual HD", NULL, BLIST_NO_RSOC},
> >>> +	{"MSFT", "Virtual HD", NULL, BLIST_MAX_1024 | BLIST_NO_RSOC},
> >
> > Ross,
> >
> > What about storage_channel_properties.max_transfer_bytes returned
> from VSTOR_OPERATION_QUERY_PROPERTIES (in storvsc_channel_init())
> >
> > Does it return correctly the maximum transfer size for iSCSI?
> >
> 
> I presume you're referring to the Hyper-V virtual storage driver? This
> has nothing to do with that module -- I don't even have it compiled in.
> It's just simply the Linux kernel initiator connecting over plain
> software iSCSI to a Windows Server 2016 iSCSI target.
> 
> This is easy enough to reproduce. Just set up a Windows Server 2016
> target and try and use it from Linux. You get I/O errors as soon as you
> try and format the disk.

Adding Matt for visibility. Ross, we are fine with blacklisting for now.

K. Y 
> 
> Cheers,
> --
> Ross Lagerwall