lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 05 Apr 2018 13:24:31 -0700
From:   Stephen Boyd <>
To:     "Gustavo A. R. Silva" <>,
        Chanwoo Choi <>,
        Krzysztof Kozlowski <>,
        Kukjin Kim <>,
        Michael Turquette <>,
        Sylwester Nawrocki <>,
        Tomasz Figa <>
        "Gustavo A. R. Silva" <>
Subject: Re: [PATCH] clk: samsung: s3c: Mark expected switch fall-through

Quoting Gustavo A. R. Silva (2018-04-03 18:09:31)
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> Notice that in this particular case I replaced the comma wiht a dash,


> which is what GCC is expecting to find when there are other comments
> in the same line in which "fall through" appears.
> Signed-off-by: Gustavo A. R. Silva <>
> ---
> This code was compiled with GCC 7.3.0

What's the GCC warning? Please include in the commit text.

Also what's the implicit-fallthrough level you're using? 3? Can you file
a bug so GCC can update their regex to accept a comma in addition to
whitespace characters?

And maybe we can change the level to 2 or 1 in the kernel's makefile so
we don't need to patch comments for this.

Powered by blists - more mailing lists