linux-kernel - Re: [PATCH 4.4 63/97] md/raid10: skip spare disk as first disk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180406073232.GD15735@kroah.com>
Date:   Fri, 6 Apr 2018 09:32:32 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Ben Hutchings <ben.hutchings@...ethink.co.uk>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Guoqing Jiang <gqjiang@...e.com>, NeilBrown <neilb@...e.com>,
        Shaohua Li <shli@...com>,
        Sasha Levin <alexander.levin@...rosoft.com>
Subject: Re: [PATCH 4.4 63/97] md/raid10: skip spare disk as first disk

On Tue, Apr 03, 2018 at 10:32:09PM +0100, Ben Hutchings wrote:
> On Fri, 2018-03-23 at 10:54 +0100, Greg Kroah-Hartman wrote:
> > 4.4-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Shaohua Li <shli@...com>
> > 
> > 
> > [ Upstream commit b506335e5d2b4ec687dde392a3bdbf7601778f1d ]
> > 
> > Commit 6f287ca(md/raid10: reset the 'first' at the end of loop) ignores
> > a case in reshape, the first rdev could be a spare disk, which shouldn't
> > be accounted as the first disk since it doesn't include the offset info.
> > 
> > Fix: 6f287ca(md/raid10: reset the 'first' at the end of loop)
> 
> But that commit hasn't been applied to 4.4-stable.  It probably should
> be, since it fixes another instance of the problem in the run()
> function.  Take care not to add the wrongly placed assignment
> in raid10_start_reshape().

Thanks, now fixed up.

greg k-h