linux-kernel - Re: [PATCH v2] pstore: fix crypto dependencies without compression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0dnD48qGWL098_fvqC=BOCm5x6DfC9aQ8qv0JZ-EehYA@mail.gmail.com>
Date:   Fri, 6 Apr 2018 09:56:55 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Tobias Regnery <tobias.regnery@...il.com>
Cc:     Kees Cook <keescook@...omium.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] pstore: fix crypto dependencies without compression

On Fri, Apr 6, 2018 at 9:25 AM, Tobias Regnery <tobias.regnery@...il.com> wrote:
> Commit 58eb5b670747 ("pstore: fix crypto dependencies") fixed up the crypto
> dependencies but missed the case when no compression is selected.
>
> With CONFIG_PSTORE=y, CONFIG_PSTORE_COMPRESS=n  and CONFIG_CRYPTO=m we see
> the following link error:
>
> fs/pstore/platform.o: In function `pstore_register':
> (.text+0x1b1): undefined reference to `crypto_has_alg'
> (.text+0x205): undefined reference to `crypto_alloc_base'
> fs/pstore/platform.o: In function `pstore_unregister':
> (.text+0x3b0): undefined reference to `crypto_destroy_tfm'
>
> Fix this by checking at compile-time if CONFIG_PSTORE_COMPRESS is enabled.
>
> Fixes: 58eb5b670747 ("pstore: fix crypto dependencies")
> Signed-off-by: Tobias Regnery <tobias.regnery@...il.com>
> ---
> v2: check the config at compile-time rather than change the
>     kconfig-dependency as suggested by Arnd.

Thanks!

Acked-by: Arnd Bergmann <arnd@...db.de>