linux-kernel - Re: [PATCH v2] staging: greybus: Fix warning to limit chars per line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180406103532.GA3572@vireshk-i7>
Date:   Fri, 6 Apr 2018 16:05:32 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Gaurav Dhingra <gauravdhingra.gxyd@...il.com>
Cc:     Vaibhav Agarwal <vaibhav.sr@...il.com>,
        Mark Greer <mgreer@...malcreek.com>,
        Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
        greybus-dev@...ts.linaro.org,
        driver-dev <devel@...verdev.osuosl.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] staging: greybus: Fix warning to limit chars per line

On 06-04-18, 16:02, Gaurav Dhingra wrote:
> I didn't realize that it would be necessary to add it to this patch set. I
> thought you guys will do squashing of the commits (v2 and v1) and using just
> one commit message (and will take it from last commit), seems like I was
> wrong. Now I've understood it.

:)

When you send V2, it doesn't have any dependency on V1 and V1 is
discarded after that point. V2 is the full patch which should be
applied alone, we mention V2 in subject so that it is easier to track
the versions.

> >>Signed-off-by: Gaurav Dhingra <gauravdhingra.gxyd@...il.com>
> >>---
> >>Changes in v2:
> >>     - use correct format for multiline comment
> >>---
> >>  drivers/staging/greybus/audio_codec.h | 5 ++++-
> >>  1 file changed, 4 insertions(+), 1 deletion(-)
> >>
> >>diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h
> >>index a1d5440..4efd8b3 100644
> >>--- a/drivers/staging/greybus/audio_codec.h
> >>+++ b/drivers/staging/greybus/audio_codec.h
> >>@@ -23,7 +23,10 @@ enum {
> >>         NUM_CODEC_DAIS,
> >>  };
> >>
> >>-/* device_type should be same as defined in audio.h (Android media layer) */
> >>+/*
> >>+ * device_type should be same as defined in audio.h
> >>+ * (Android media layer)
> >>+ */
> >>  enum {
> >>         GBAUDIO_DEVICE_NONE                     = 0x0,
> >>         /* reserved bits */
> >This looks ok.
> 
> Do I now need to send v3 with these exact changes, since I missed the
> 'commit log' in this one?

Yes please.

-- 
viresh