lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <e94e085f-6b66-5a2f-9654-0ba47d13249b@gmail.com>
Date:   Fri, 6 Apr 2018 08:02:56 -0500
From:   Stuart Hayes <stuart.w.hayes@...il.com>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     linux-kernel@...r.kernel.org, Douglas_Warzecha@...l.com
Subject: Re: [PATCH v3] dell_rbu: make firmware payload memory uncachable


On 4/4/2018 3:30 PM, Takashi Iwai wrote:
> On Wed, 28 Mar 2018 17:07:47 +0200,
> Stuart Hayes wrote:
>>
>> @@ -180,6 +181,12 @@ static int create_packet(void *data, size_t length)
>>  			invalid_addr_packet_array[idx++] = packet_data_temp_buf;
>>  			packet_data_temp_buf = NULL;
>>  		}
>> +		/*
>> +		 * set to uncachable or it may never get written back before
>> +		 * reboot
>> +		 */
>> +		set_memory_uc((unsigned long)packet_data_temp_buf,
>> +			1 << ordernum);
> 
> Won't this cause Oops when the if-condition above meets?
> Namely packet_data_temp_buf is set to NULL there.
> 
> Maybe better to try a fault injection to check the error handling.
> 
> 
> thanks,
> 
> Takashi
> 

Yes, thank you for catching my mistake.
Stuart

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ