linux-kernel - Re: [PATCH 01/10] staging: fnic2 add initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20180406050752.GC27591@kroah.com>
Date:   Fri, 6 Apr 2018 07:07:52 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Oliver Smith-Denny <osmithde@...co.com>
Cc:     Sesidhar Baddela <sebaddel@...co.com>,
        Gian Carlo Boffa <gcboffa@...co.com>,
        linux-scsi@...r.kernel.org, target-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/10] staging: fnic2 add initialization

On Thu, Apr 05, 2018 at 02:16:45PM -0700, Oliver Smith-Denny wrote:
> These files contain module load and unload, global driver context,
> PCI registration, PCI probe and remove, and definitions of
> the fnic2 global context.
> 
> Signed-off-by: Oliver Smith-Denny <osmithde@...co.com>
> Signed-off-by: Sesidhar Baddela <sebaddel@...co.com>
> Signed-off-by: Anil Chintalapati <achintal@...co.com>
> Signed-off-by: Arulprabhu Ponnusamy <arulponn@...co.com>
> Signed-off-by: Gian Carlo Boffa <gcboffa@...co.com>
> Co-Developed-by: Arulprabhu Ponnusamy <arulponn@...co.com>
> Co-Developed-by: Gian Carlo Boffa <gcboffa@...co.com>
> Co-Developed-by: Oliver Smith-Denny <osmithde@...co.com>
> ---
>  drivers/staging/fnic2/src/fnic2.h      | 256 ++++++++++++
>  drivers/staging/fnic2/src/fnic2_main.c | 711 +++++++++++++++++++++++++++++++++
>  2 files changed, 967 insertions(+)
>  create mode 100644 drivers/staging/fnic2/src/fnic2.h
>  create mode 100644 drivers/staging/fnic2/src/fnic2_main.c

Why is this a drivers/staging/ driver at all?  What is keeping you from
getting this merged into the "proper" place in the kernel?

If you have a staging driver, you have to have a TODO file in the
directory listing what is keeping this in the staging section.

Also, one tiny thing to fix up:

> --- /dev/null
> +++ b/drivers/staging/fnic2/src/fnic2.h
> @@ -0,0 +1,256 @@
> +/*
> + * SPDX-License-Identifier: GPL-2.0

Please read the documentation on how to properly use SPDX tags on kernel
files.  This needs to be the first line of the file.

thanks,

greg k-h