linux-kernel - Re: [4.9, 137/145] spi: bcm-qspi: shut up warning about cfi header inclusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <21fcc6ff-d3f8-a863-224c-a31746c2db0c@gmail.com>
Date:   Fri, 6 Apr 2018 08:55:02 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Arnd Bergmann <arnd@...db.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "# 3.4.x" <stable@...r.kernel.org>,
        Kamal Dasu <kdasu.kdev@...il.com>
Subject: Re: [4.9, 137/145] spi: bcm-qspi: shut up warning about cfi header
 inclusion



On 04/06/2018 12:22 AM, Arnd Bergmann wrote:
> On Fri, Apr 6, 2018 at 9:09 AM, gregkh@...uxfoundation.org
> <gregkh@...uxfoundation.org> wrote:
>> On Tue, Apr 03, 2018 at 10:46:07AM -0700, Florian Fainelli wrote:
>>> On 02/23/2018 10:27 AM, gregkh@...uxfoundation.org wrote:
>>>> 4.9-stable review patch.  If anyone has any objections, please let me know.
>>>>
>>>> ------------------
>>>>
>>>> From: Arnd Bergmann <arnd@...db.de>
>>>>
>>>> When CONFIG_MTD_CFI is disabled, we get a warning for this spi driver:
>>>>
>>>> include/linux/mtd/cfi.h:76:2: #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work. [-Werror=cpp]
>>>>
>>>> The problem here is a layering violation that was fixed in mainline kernels with
>>>> a larger rework in commit 054e532f8f90 ("spi: bcm-qspi: Remove hardcoded settings
>>>> and spi-nor.h dependency"). We can't really backport that to stable kernels, so
>>>> this just adds a Kconfig dependency to make it either build cleanly or force it
>>>> to be disabled.
>>>
>>> Sorry for noticing so late, but this appears to be bogus, there is no
>>> MTD_NORFLASH symbol being defined in 4.9, in fact I can't find this
>>> Kconfig symbol in any kernel version, so this effectively results in the
>>> driver no longer being selectable, so this sure does silence the warning.
>>>
>>> Arnd, should we just send reverts of this patch for the affected kernel
>>> or should we be defining MTD_NORFLASH somehow? Am I missing something here?
>>
>> I'm going to revert this patch for now, thanks.
> 
> Yes, please do. Sorry for missing Florian's bug report. I looked at it again
> and found that it was never intended for backports to 4.9, as the regression
> addressed by the patch was originally merged into 4.14-rc1.

No worries, thanks both!
--
Florian