linux-kernel - Re: [PATCH] staging: greybus: Fix warning to limit chars per line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 6 Apr 2018 09:01:34 -0700
From:   Mark Greer <mgreer@...malcreek.com>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     Mark Greer <mgreer@...malcreek.com>,
        Gaurav Dhingra <gauravdhingra.gxyd@...il.com>,
        Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: greybus: Fix warning to limit chars per line

On Fri, Apr 06, 2018 at 10:52:17AM +0530, Viresh Kumar wrote:
> On Fri, Apr 6, 2018 at 3:49 AM, Mark Greer <mgreer@...malcreek.com> wrote:
> > On Wed, Apr 04, 2018 at 12:02:46AM +0530, Gaurav Dhingra wrote:
> >> Wrap comment to fix warning "prefer a maximum 75 chars per line"
> >>
> >> Signed-off-by: Gaurav Dhingra <gauravdhingra.gxyd@...il.com>
> >> ---
> >>  drivers/staging/greybus/audio_codec.h | 4 +++-
> >>  1 file changed, 3 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h
> >> index a1d5440..01838d9 100644
> >> --- a/drivers/staging/greybus/audio_codec.h
> >> +++ b/drivers/staging/greybus/audio_codec.h
> >> @@ -23,7 +23,9 @@ enum {
> >>       NUM_CODEC_DAIS,
> >>  };
> >>
> >> -/* device_type should be same as defined in audio.h (Android media layer) */
> >> +/* device_type should be same as defined in audio.h
> 
> This isn't the right way to write a multi-line comment. It should be like:
> 
> /*
>  * XXXX
>  * XXXX
>  */

Ugh, yeah, you're right.  I must have been sleeping.

Mark
--