lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20180407011714.GC386@tigerII.localdomain> Date: Sat, 7 Apr 2018 10:17:14 +0900 From: Sergey Senozhatsky <sergey.senozhatsky@...il.com> To: Joe Perches <joe@...ches.com> Cc: Sergey Senozhatsky <sergey.senozhatsky@...il.com>, Rasmus Villemoes <linux@...musvillemoes.dk>, Petr Mladek <pmladek@...e.com>, Linus Torvalds <torvalds@...ux-foundation.org>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, "Tobin C . Harding" <me@...in.cc>, Andrew Morton <akpm@...ux-foundation.org>, Michal Hocko <mhocko@...e.cz>, Steven Rostedt <rostedt@...dmis.org>, Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH v4 4/9] vsprintf: Consolidate handling of unknown pointer specifiers On (04/06/18 18:00), Joe Perches wrote: [..] > This finds the current two bad uses in addition to > the existing similar message for string concatenation > without a space char between concatenated fragments. > > For example: > > WARNING: break quoted strings at a space character > #3550: FILE: drivers/scsi/megaraid/megaraid_sas_base.c:3550: > + dev_notice(&instance->pdev->dev, "moving cmd[%d]:%p:%d:%p" > + "on the defer queue as internal\n", > > WARNING: vsprintf %p<extension> string concatenation > #3550: FILE: drivers/scsi/megaraid/megaraid_sas_base.c:3550: > + dev_notice(&instance->pdev->dev, "moving cmd[%d]:%p:%d:%p" > + "on the defer queue as internal\n", > > I think the new message is not that useful really as the > existing warning is probably enough. Oh, so we already have it... Didn't know that. Yes, I think the existing one is good enough. Thanks for the pointers. -ss
Powered by blists - more mailing lists