linux-kernel - Re: [PATCH 4/4 v2] init: Have initcall_debug still work without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201804071528.w0U8JAKp%fengguang.wu@intel.com>
Date:   Sat, 7 Apr 2018 16:18:30 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Frederic Weisbecker <fweisbec@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        "Joel Fernandes (Google)" <joel.opensrc@...il.com>
Subject: Re: [PATCH 4/4 v2] init: Have initcall_debug still work without
 CONFIG_TRACEPOINTS

Hi Steven,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v4.16 next-20180406]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Steven-Rostedt/init-tracing/20180407-130743
config: i386-randconfig-x006-201813 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

>> init/main.c:849:15: warning: return type defaults to 'int' [-Wreturn-type]
    static inline initcall_debug_enable(void)
                  ^~~~~~~~~~~~~~~~~~~~~
>> init/main.c:849:15: warning: conflicting types for 'initcall_debug_enable'
   init/main.c:499:20: note: previous declaration of 'initcall_debug_enable' was here
    static void __init initcall_debug_enable(void);
                       ^~~~~~~~~~~~~~~~~~~~~

vim +/int +849 init/main.c

   834	
   835	#ifdef TRACEPOINTS_ENABLED
   836	static void __init initcall_debug_enable(void)
   837	{
   838		int ret;
   839	
   840		ret = register_trace_initcall_start(trace_initcall_start_cb,
   841						    &initcall_calltime);
   842		ret |= register_trace_initcall_finish(trace_initcall_finish_cb,
   843						      &initcall_calltime);
   844		WARN(ret, "Failed to register initcall tracepoints\n");
   845	}
   846	# define do_trace_initcall_start	trace_initcall_start
   847	# define do_trace_initcall_finish	trace_initcall_finish
   848	#else
 > 849	static inline initcall_debug_enable(void)
   850	{
   851	}
   852	static inline void do_trace_initcall_start(initcall_t fn)
   853	{
   854		if (!initcall_debug)
   855			return;
   856		trace_initcall_start_cb(&initcall_calltime, fn);
   857	}
   858	static inline void do_trace_initcall_finish(initcall_t fn, int ret)
   859	{
   860		if (!initcall_debug)
   861			return;
   862		trace_initcall_finish_cb(&initcall_calltime, fn, ret);
   863	}
   864	#endif /* !TRACEPOINTS_ENABLED */
   865	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (35103 bytes)