linux-kernel - Re: [PATCH 1/2] iio: sca3000: Fix an error handling path in 'sca3000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180408173220.7f2483c7@archlinux>
Date:   Sun, 8 Apr 2018 17:32:20 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
        nfarnesi4@...il.com, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/2] iio: sca3000: Fix an error handling path in
 'sca3000_probe()'

On Mon,  2 Apr 2018 18:59:42 +0200
Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote:

> In case of error, we must undo the previous 'sca3000_configure_ring()' call
> in order to free some memory.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Perhaps we can simplify this by using devm_iio_kfifo_allocate in
the ring configure function?

> ---
>  drivers/iio/accel/sca3000.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c
> index f33dadf7b262..dae4c594c170 100644
> --- a/drivers/iio/accel/sca3000.c
> +++ b/drivers/iio/accel/sca3000.c
> @@ -1496,7 +1496,7 @@ static int sca3000_probe(struct spi_device *spi)
>  					   "sca3000",
>  					   indio_dev);
>  		if (ret)
> -			return ret;
> +			goto error_unconfigure_ring;
>  	}
>  	indio_dev->setup_ops = &sca3000_ring_setup_ops;
>  	ret = sca3000_clean_setup(st);
> @@ -1513,6 +1513,9 @@ static int sca3000_probe(struct spi_device *spi)
>  	if (spi->irq)
>  		free_irq(spi->irq, indio_dev);
>  
> +error_unconfigure_ring:
> +	sca3000_unconfigure_ring(indio_dev);
> +
>  	return ret;
>  }
>