linux-kernel - Re: [PATCH] tools/memory-model: Update required version of herdtools7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180408212141.GV3948@linux.vnet.ibm.com>
Date:   Sun, 8 Apr 2018 14:21:41 -0700
From:   "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:     Akira Yokosawa <akiyks@...il.com>
Cc:     Alan Stern <stern@...land.harvard.edu>,
        Andrea Parri <parri.andrea@...il.com>,
        Will Deacon <will.deacon@....com>,
        Peter Zijlstra <peterz@...radead.org>,
        Boqun Feng <boqun.feng@...il.com>,
        Nicholas Piggin <npiggin@...il.com>,
        David Howells <dhowells@...hat.com>,
        Jade Alglave <j.alglave@....ac.uk>,
        Luc Maranget <luc.maranget@...ia.fr>,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools/memory-model: Update required version of herdtools7

On Sun, Apr 08, 2018 at 09:18:08AM +0900, Akira Yokosawa wrote:
> >From 64542a47acf159d26b8290480c0af9c2a05d20d6 Mon Sep 17 00:00:00 2001
> From: Akira Yokosawa <akiyks@...il.com>
> Date: Sun, 8 Apr 2018 07:44:55 +0900
> Subject: [PATCH] tools/memory-model: Update required version of herdtools7
> 
> Code generated by klitmus7 version 7.48 doesn't compile with kernel
> header of 4.15 and later due to the absence of ACCESS_ONCE().
> As the issue has been resolved in herdtools7 7.49, bump the required
> version number in README.
> 
> Signed-off-by: Akira Yokosawa <akiyks@...il.com>
> Cc: Alan Stern <stern@...land.harvard.edu>
> Cc: Andrea Parri <parri.andrea@...il.com>
> Cc: Will Deacon <will.deacon@....com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Boqun Feng <boqun.feng@...il.com>
> Cc: Nicholas Piggin <npiggin@...il.com>
> Cc: David Howells <dhowells@...hat.com>
> Cc: Jade Alglave <j.alglave@....ac.uk>
> Cc: Luc Maranget <luc.maranget@...ia.fr>
> Cc: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
> Cc: Ingo Molnar <mingo@...hat.com>
> ---
> Hi Paul,
> 
> I think this is a 4.17 matter.
> Thoughts?

Good catch, queued and pushed, thank you!

I don't believe that this needs to go into the current merge window,
given that there is an easy workaround and that people running into this
will likely find your patch via web-seach, at which point they can update
their herdtools.  But it should definitely go into v4.18!

							Thanx, Paul

>         Thanks, Akira
> --
>  tools/memory-model/README | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/memory-model/README b/tools/memory-model/README
> index 0b3a5f3..734f7fe 100644
> --- a/tools/memory-model/README
> +++ b/tools/memory-model/README
> @@ -20,7 +20,7 @@ that litmus test to be exercised within the Linux kernel.
>  REQUIREMENTS
>  ============
> 
> -Version 7.48 of the "herd7" and "klitmus7" tools must be downloaded
> +Version 7.49 of the "herd7" and "klitmus7" tools must be downloaded
>  separately:
> 
>    https://github.com/herd/herdtools7
> -- 
> 2.7.4
>