linux-kernel - Re: [PATCH 2/4] arm64: usercopy: implement arch_within_stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+KhAHZB2tDpd-EY8har78PWyf=SCN4cNSjLHLpRqZoJgB2TiQ@mail.gmail.com>
Date:   Sun, 8 Apr 2018 10:39:24 +0400
From:   Keun-O Park <kpark3469@...il.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     Kernel Hardening <kernel-hardening@...ts.openwall.com>,
        James Morse <james.morse@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Mark Rutland <mark.rutland@....com>, keun-o.park@...kmatter.ae,
        Sodagudi Prasad <psodagud@...eaurora.org>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Ingo Molnar <mingo@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] arm64: usercopy: implement arch_within_stack_frames

Hi Kees,

On Thu, Apr 5, 2018 at 2:55 AM, Kees Cook <keescook@...omium.org> wrote:
> On Thu, Mar 1, 2018 at 2:19 AM,  <kpark3469@...il.com> wrote:
>> From: James Morse <james.morse@....com>
>>
>> This implements arch_within_stack_frames() for arm64 that should
>> validate if a given object is contained by a kernel stack frame.
>>
>> Signed-off-by: James Morse <james.morse@....com>
>> Reviewed-by: Sahara <keun-o.park@...kmatter.ae>
>
> Looks good to me. Does this end up passing the LKDTM
> USERCOPY_STACK_FRAME_TO and USERCOPY_STACK_FRAME_FROM tests?

Yes, this passes those two LKDTM tests.
Thanks.

BR
Sahara