lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAJHCu1KkNgiFR1cZ+T6-+t5-41theqVsLU8umgqLi8JWhs2nxw@mail.gmail.com> Date: Sun, 8 Apr 2018 10:56:17 +0200 From: Salvatore Mesoraca <s.mesoraca16@...il.com> To: Herbert Xu <herbert@...dor.apana.org.au> Cc: linux-kernel@...r.kernel.org, Kernel Hardening <kernel-hardening@...ts.openwall.com>, linux-crypto@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Kees Cook <keescook@...omium.org>, Eric Biggers <ebiggers3@...il.com>, Laura Abbott <labbott@...hat.com> Subject: Re: [PATCH 1/6] crypto: api - laying macros for statically allocated buffers 2018-04-08 5:15 GMT+02:00 Herbert Xu <herbert@...dor.apana.org.au>: > On Sat, Apr 07, 2018 at 08:38:18PM +0200, Salvatore Mesoraca wrote: >> Creating 2 new compile-time constants for internal use, >> in preparation for the removal of VLAs[1] from crypto code. >> All ciphers implemented in Linux have a block size less than or >> equal to 16 bytes and the most demanding hw require 16 bytes >> alignment for the block buffer. >> >> [1] http://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com >> >> Signed-off-by: Salvatore Mesoraca <s.mesoraca16@...il.com> >> --- >> crypto/internal.h | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/crypto/internal.h b/crypto/internal.h >> index 9a3f399..89ae41e 100644 >> --- a/crypto/internal.h >> +++ b/crypto/internal.h >> @@ -26,6 +26,14 @@ >> #include <linux/rwsem.h> >> #include <linux/slab.h> >> >> +/* >> + * Maximum values for blocksize and alignmask, used to allocate >> + * static buffers that are big enough for any combination of >> + * ciphers and architectures. >> + */ >> +#define MAX_BLOCKSIZE 16 >> +#define MAX_ALIGNMASK 15 > > No please don't put this here if you intend on using it everywhere. > This file is reserved for truly internal bits. > > Perhaps include/crypto/algapi.h would be a better place. OK, thank you for the suggestion :) Salvatore
Powered by blists - more mailing lists