| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAHp75VfSH5_N=tfJuw25ddD_rLvB7+irSyOW=dvAhAcwY9g+gg@mail.gmail.com>
Date: Mon, 9 Apr 2018 11:09:28 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Hans de Goede <hdegoede@...hat.com>
Cc: Darren Hart <dvhart@...radead.org>,
Andy Shevchenko <andy@...radead.org>,
Ard Biesheuvel <ard.biesheuvel@...aro.org>,
"Luis R . Rodriguez" <mcgrof@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>,
"H . Peter Anvin" <hpa@...or.com>,
Platform Driver <platform-driver-x86@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Peter Jones <pjones@...hat.com>,
Dave Olsthoorn <dave@...aar.me>,
Will Deacon <will.deacon@....com>,
Andy Lutomirski <luto@...nel.org>,
Matt Fleming <matt@...eblueprint.co.uk>,
David Howells <dhowells@...hat.com>,
Mimi Zohar <zohar@...ux.vnet.ibm.com>,
Josh Triplett <josh@...htriplett.org>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
mfuzzey@...keon.com, Kees Cook <keescook@...omium.org>,
Kalle Valo <kvalo@...eaurora.org>,
Arend Van Spriel <arend.vanspriel@...adcom.com>,
Linus Torvalds <torvalds@...ux-foundation.org>,
nbroeking@...com, Bjorn Andersson <bjorn.andersson@...aro.org>,
Torsten Duwe <duwe@...e.de>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
linux-efi <linux-efi@...r.kernel.org>
Subject: Re: [PATCH v2 4/5] platform/x86: touchscreen_dmi: Add EFI embedded
firmware info support
On Sun, Apr 8, 2018 at 8:26 PM, Hans de Goede <hdegoede@...hat.com> wrote:
> Sofar we have been unable to get permission from the vendors to put the
> firmware for touchscreens listed in touchscreen_dmi in linux-firmware.
>
> Some of the tablets with such a touchscreen have a touchscreen driver, and
> thus a copy of the firmware, as part of their EFI code.
>
> This commit adds the necessary info for the new EFI embedded-firmware code
> to extract these firmwares, making the touchscreen work OOTB without the
> user needing to manually add the firmware.
>
Acked-by: Andy Shevchenko <andy.shevchenko@...il.com>
for PDx86 bits only.
> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
> ---
> drivers/firmware/efi/embedded-firmware.c | 3 +++
> drivers/platform/x86/Kconfig | 1 +
> drivers/platform/x86/touchscreen_dmi.c | 26 +++++++++++++++++++++++-
> include/linux/efi_embedded_fw.h | 2 ++
> 4 files changed, 31 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/embedded-firmware.c b/drivers/firmware/efi/embedded-firmware.c
> index cb57225a340d..26101ac1a282 100644
> --- a/drivers/firmware/efi/embedded-firmware.c
> +++ b/drivers/firmware/efi/embedded-firmware.c
> @@ -23,6 +23,9 @@ struct embedded_fw {
> static LIST_HEAD(found_fw_list);
>
> static const struct dmi_system_id * const embedded_fw_table[] = {
> +#ifdef CONFIG_TOUCHSCREEN_DMI
> + touchscreen_dmi_table,
> +#endif
> NULL
> };
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index b836576f0fe4..5bb0f5edd7f2 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1197,6 +1197,7 @@ config INTEL_TURBO_MAX_3
> config TOUCHSCREEN_DMI
> bool "DMI based touchscreen configuration info"
> depends on ACPI && DMI && I2C=y && TOUCHSCREEN_SILEAD
> + select EFI_EMBEDDED_FIRMWARE if EFI_STUB
> ---help---
> Certain ACPI based tablets with e.g. Silead or Chipone touchscreens
> do not have enough data in ACPI tables for the touchscreen driver to
> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
> index 87fc839b28f7..6488cd50ba79 100644
> --- a/drivers/platform/x86/touchscreen_dmi.c
> +++ b/drivers/platform/x86/touchscreen_dmi.c
> @@ -15,12 +15,15 @@
> #include <linux/acpi.h>
> #include <linux/device.h>
> #include <linux/dmi.h>
> +#include <linux/efi_embedded_fw.h>
> #include <linux/i2c.h>
> #include <linux/notifier.h>
> #include <linux/property.h>
> #include <linux/string.h>
>
> struct ts_dmi_data {
> + /* The EFI embedded-fw code expects this to be the first member! */
> + struct efi_embedded_fw_desc embedded_fw;
> const char *acpi_name;
> const struct property_entry *properties;
> };
> @@ -31,10 +34,17 @@ static const struct property_entry cube_iwork8_air_props[] = {
> PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
> PROPERTY_ENTRY_STRING("firmware-name", "gsl3670-cube-iwork8-air.fw"),
> PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> + PROPERTY_ENTRY_BOOL("efi-embedded-firmware"),
> { }
> };
>
> static const struct ts_dmi_data cube_iwork8_air_data = {
> + .embedded_fw = {
> + .name = "silead/gsl3670-cube-iwork8-air.fw",
> + .prefix = { 0xf0, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00 },
> + .length = 38808,
> + .crc = 0xfecde51f,
> + },
> .acpi_name = "MSSL1680:00",
> .properties = cube_iwork8_air_props,
> };
> @@ -119,10 +129,17 @@ static const struct property_entry pipo_w2s_props[] = {
> PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
> PROPERTY_ENTRY_STRING("firmware-name",
> "gsl1680-pipo-w2s.fw"),
> + PROPERTY_ENTRY_BOOL("efi-embedded-firmware"),
> { }
> };
>
> static const struct ts_dmi_data pipo_w2s_data = {
> + .embedded_fw = {
> + .name = "silead/gsl1680-pipo-w2s.fw",
> + .prefix = { 0xf0, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00 },
> + .length = 39072,
> + .crc = 0x28d5dc6c,
> + },
> .acpi_name = "MSSL1680:00",
> .properties = pipo_w2s_props,
> };
> @@ -162,10 +179,17 @@ static const struct property_entry chuwi_hi8_pro_props[] = {
> PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
> PROPERTY_ENTRY_STRING("firmware-name", "gsl3680-chuwi-hi8-pro.fw"),
> PROPERTY_ENTRY_BOOL("silead,home-button"),
> + PROPERTY_ENTRY_BOOL("efi-embedded-firmware"),
> { }
> };
>
> static const struct ts_dmi_data chuwi_hi8_pro_data = {
> + .embedded_fw = {
> + .name = "silead/gsl3680-chuwi-hi8-pro.fw",
> + .prefix = { 0xf0, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00 },
> + .length = 39864,
> + .crc = 0xfe2bedba,
> + },
> .acpi_name = "MSSL1680:00",
> .properties = chuwi_hi8_pro_props,
> };
> @@ -277,7 +301,7 @@ static const struct ts_dmi_data teclast_x3_plus_data = {
> .properties = teclast_x3_plus_props,
> };
>
> -static const struct dmi_system_id touchscreen_dmi_table[] = {
> +const struct dmi_system_id touchscreen_dmi_table[] = {
> {
> /* CUBE iwork8 Air */
> .driver_data = (void *)&cube_iwork8_air_data,
> diff --git a/include/linux/efi_embedded_fw.h b/include/linux/efi_embedded_fw.h
> index 0f7d4df3f57a..4c8cfe38ec02 100644
> --- a/include/linux/efi_embedded_fw.h
> +++ b/include/linux/efi_embedded_fw.h
> @@ -20,6 +20,8 @@ struct efi_embedded_fw_desc {
> u32 crc;
> };
>
> +extern const struct dmi_system_id touchscreen_dmi_table[];
> +
> int efi_get_embedded_fw(const char *name, void **dat, size_t *sz, size_t msize);
>
> #endif
> --
> 2.17.0
>
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists