linux-kernel - Re: [PATCH] kvm: x86: fix a prototype warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7055d28b-10f4-eb22-069c-ea6e0a7037f3@redhat.com>
Date:   Mon, 9 Apr 2018 12:59:26 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Peng Hao <peng.hao2@....com.cn>, pbonzini@...hat.com,
        rkrcmar@...hat.com, tglx@...utronix.de, mingo@...hat.com,
        hpa@...or.com
Cc:     x86@...nel.org, kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kvm: x86: fix a prototype warning

On 06.04.2018 23:47, Peng Hao wrote:
> warning: no previous prototype for ‘vmx_enable_tdp’
> 
> Signed-off-by: Peng Hao <peng.hao2@....com.cn>
> ---
>  arch/x86/kvm/vmx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index f0fd50b..86681bc 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -6954,7 +6954,7 @@ static void wakeup_handler(void)
>  	spin_unlock(&per_cpu(blocked_vcpu_on_cpu_lock, cpu));
>  }
>  
> -void vmx_enable_tdp(void)
> +static void vmx_enable_tdp(void)
>  {
>  	kvm_mmu_set_mask_ptes(VMX_EPT_READABLE_MASK,
>  		enable_ept_ad_bits ? VMX_EPT_ACCESS_BIT : 0ull,
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 

Thanks,

David / dhildenb