linux-kernel - Re: [PATCH AUTOSEL for 4.15 142/189] firmware: dmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPxHnE3RLALDXA6OwMT6CKUM5U9vPo_--Wq8t7MZRwz04Gzu=w@mail.gmail.com>
Date:   Mon, 9 Apr 2018 09:44:28 -0400
From:   Parag Warudkar <parag.warudkar@...il.com>
To:     Jean Delvare <jdelvare@...e.de>
Cc:     Sasha Levin <Alexander.Levin@...rosoft.com>,
        stable@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH AUTOSEL for 4.15 142/189] firmware: dmi_scan: Fix handling
 of empty DMI strings

On Mon, Apr 9, 2018 at 8:48 AM, Jean Delvare <jdelvare@...e.de> wrote:
> As a conclusion, it's doable, but the benefit is very small and limited
> to a few broken systems, and it has the downside of not discouraging
> low-quality tables, so my position is that it's not worth it and not
> desirable.

Thanks for the explanation Jean, I just wanted to make sure we are not
going back to the original problem of allocating lots of memory for
lots of spaces. Given the limited benefit and low likelihood of
encountering lots of strings with lots of leading and trailing spaces,
I agree, it's best to stick to the spec. And it's also no longer a
static 2048 byte array we are allocating from anymore!

--Parag