linux-kernel - Re: [PATCH] backing: silence compiler warning using _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f8d37511-2a23-53f5-3c70-8a7f5f9e965e@kernel.dk>
Date:   Mon, 9 Apr 2018 09:51:41 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Mathieu Malaterre <malat@...ian.org>
Cc:     Jan Kara <jack@...e.cz>, Andrew Morton <akpm@...ux-foundation.org>,
        Nikolay Borisov <nborisov@...e.com>, Tejun Heo <tj@...nel.org>,
        Matthew Wilcox <mawilcox@...rosoft.com>,
        Minchan Kim <minchan@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] backing: silence compiler warning using __printf

On 4/6/18 2:14 PM, Mathieu Malaterre wrote:
> __printf marker was added in commit d2cc4dde9206 ("bdi_register: add
> __printf verification, fix arg mismatch") for function `bdi_register`
> since it is useful to verify format and arguments. Apply equivalent gcc
> attribute to `bdi_register_va`.
> 
> Remove warning triggered with W=1:
> 
>   mm/backing-dev.c:881:2: warning: function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]

Applied, thanks.

-- 
Jens Axboe