linux-kernel - Re: [PATCH] tick-sched: avoid a maybe-uninitialized warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180409161817.bnmokplnoagyxwrc@gmail.com>
Date:   Mon, 9 Apr 2018 18:18:17 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Frederic Weisbecker <fweisbec@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tick-sched: avoid a maybe-uninitialized warning


* Arnd Bergmann <arnd@...db.de> wrote:

> The use of bitfields seems to confuse gcc, leading to a false-positive
> warning in all compiler versions:
> 
> kernel/time/tick-sched.c: In function 'tick_nohz_idle_exit':
> kernel/time/tick-sched.c:538:2: error: 'now' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> This introduces a temporary variable to track the flags so gcc
> doesn't have to evaluate twice, eliminating the code path that
> leads to the warning.
> 
> Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85301
> Fixes: 1cae544d42d2 ("nohz: Gather tick_sched booleans under a common flag field")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Which tree is this against? There's no such commit either in -tip, upstream or in 
-next AFAICS.

Thanks,

	Ingo