linux-kernel - Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFw1MoQ=7=U6QCGXAAiCniMKy8_igxgc8sMLykSRcDk-0g@mail.gmail.com>
Date:   Mon, 9 Apr 2018 10:03:03 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Sebastian Ott <sebott@...ux.ibm.com>
Cc:     Kees Cook <keescook@...omium.org>,
        Sebastian Ott <sebott@...ux.vnet.ibm.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Martin Uecker <Martin.Uecker@....uni-goettingen.de>,
        Ingo Molnar <mingo@...nel.org>,
        Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Subject: Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on s390

On Mon, Apr 9, 2018 at 9:18 AM, Sebastian Ott <sebott@...ux.ibm.com> wrote:
>
> Both of the following return 0 on my machine:
> +       pr_warn("%u\n", min_not_zero(100, 1000));
> +       pr_warn("%u\n", min_not_zero(1000, 100));

Oooh.

[ Raises hand, and says "I know, I know, pick me, pick me" ]

min_not_zero() hasinternal variables "__x" and "__y".

And "__cmp_once()" has internal variables "__x" and "__y".

When min_not_zero does

    min(__x, __y));

that expands to crazy stuff.

Out old "min()" had the internal variables called "min1" and "min2",
which is crazy too.

             Linus