linux-kernel - Re: Subject: [PATCH] [PATCH] time: tick-sched: use bool for tick

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1804100946060.2058@nanos.tec.linutronix.de>
Date:   Tue, 10 Apr 2018 09:55:48 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     yuankuiz@...eaurora.org
cc:     linux-pm@...r.kernel.org, rjw@...ysocki.net, fweisbec@...il.com,
        peterz@...radead.org, aulmck@...ux.vnet.ibm.com, mingo@...nel.org,
        len.brown@...el.com, linux-kernel@...r.kernel.org
Subject: Re: Subject: [PATCH] [PATCH] time: tick-sched: use bool for
 tick_stopped

On Tue, 10 Apr 2018, yuankuiz@...eaurora.org wrote:

> From: John Zhao <yuankuiz@...eaurora.org>
> 
> Variable tick_stopped returned by tick_nohz_tick_stopped
> can have only true / forse values. Since the return type
> of the tick_nohz_tick_stopped is also bool, variable
> tick_stopped nice to have data type as bool in place of int.

The data type is not int. It's part of an integer bitfield and occupies
exactly one bit of storage, while bool has an architecture dependend size
and is at least 1 byte, i.e. 8 bit. So with alignment effects you grew the
size of the data structure and therefore the cache foot print.

This is not about 'nice to have' ....

Thanks,

	tglx