| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Apr 2018 09:12:32 +0800
From: kernel test robot <lkp@...el.com>
To: Dave Hansen <dave.hansen@...ux.intel.com>
Cc: Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
LKP <lkp@...org>
Subject: [lkp-robot] [bisect done] e71e836f46 [ 17.567570] WARNING: CPU: 0
PID: 1 at arch/x86/include/asm/pgtable.h:540 __change_page_attr_set_clr
Greetings,
0day kernel testing robot got the below dmesg and the first bad commit is
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/pti
commit e71e836f463dd2cfb319ce88ae4a6e4f83904e6c
Author: Dave Hansen <dave.hansen@...ux.intel.com>
AuthorDate: Fri Apr 6 13:55:11 2018 -0700
Commit: Ingo Molnar <mingo@...nel.org>
CommitDate: Mon Apr 9 18:27:33 2018 +0200
x86/mm: Remove extra filtering in pageattr code
The pageattr code has a mode where it can set or clear PTE bits in
existing PTEs, so the page protections of the *new* PTEs come from
one of two places:
1. The set/clear masks: cpa->mask_clr / cpa->mask_set
2. The existing PTE
We filter ->mask_set/clr for supported PTE bits at entry to
__change_page_attr() so we never need to filter them again.
The only other place permissions can come from is an existing PTE
and those already presumably have good bits. We do not need to filter
them again.
Signed-off-by: Dave Hansen <dave.hansen@...ux.intel.com>
Cc: Andrea Arcangeli <aarcange@...hat.com>
Cc: Andy Lutomirski <luto@...nel.org>
Cc: Arjan van de Ven <arjan@...ux.intel.com>
Cc: Borislav Petkov <bp@...en8.de>
Cc: Dan Williams <dan.j.williams@...el.com>
Cc: David Woodhouse <dwmw2@...radead.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Hugh Dickins <hughd@...gle.com>
Cc: Josh Poimboeuf <jpoimboe@...hat.com>
Cc: Juergen Gross <jgross@...e.com>
Cc: Kees Cook <keescook@...gle.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Nadav Amit <namit@...are.com>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: linux-mm@...ck.org
Link: http://lkml.kernel.org/r/20180406205511.BC072352@viggo.jf.intel.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
64c8075940 x86/mm: Do not auto-massage page protections
e71e836f46 x86/mm: Remove extra filtering in pageattr code
0564258fb2 x86/pti: Leave kernel text global for !PCID
87e1e2f51c Merge branch 'x86/pti'
+-----------------------------------------------------------------------+------------+------------+------------+------------+
| | 64c8075940 | e71e836f46 | 0564258fb2 | 87e1e2f51c |
+-----------------------------------------------------------------------+------------+------------+------------+------------+
| boot_successes | 35 | 0 | 19 | 11 |
| boot_failures | 0 | 26 | | |
| WARNING:at_arch/x86/include/asm/pgtable.h:#__change_page_attr_set_clr | 0 | 26 | | |
| RIP:__change_page_attr_set_clr | 0 | 26 | | |
+-----------------------------------------------------------------------+------------+------------+------------+------------+
[ 17.548562] #1: Loopback 1
[ 17.549344] #2: Virtual MIDI Card 1
[ 17.550337] #3: MTPAV on parallel port at 0x378
[ 17.563486] ------------[ cut here ]------------
[ 17.564783] attempted to set unsupported pgprot: 0000000000000163 bits: 0000000000000100 supported: fffffffffffffeff
[ 17.567570] WARNING: CPU: 0 PID: 1 at arch/x86/include/asm/pgtable.h:540 __change_page_attr_set_clr+0xbfa/0x1170
[ 17.570762] CPU: 0 PID: 1 Comm: swapper Not tainted 4.16.0-02286-ge71e836 #1
[ 17.572644] RIP: 0010:__change_page_attr_set_clr+0xbfa/0x1170
[ 17.574197] RSP: 0000:ffff88001e573d00 EFLAGS: 00010286
[ 17.575614] RAX: 0000000000000000 RBX: ffff88001741a000 RCX: 0000000000000000
[ 17.577519] RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffffffff83279170
[ 17.579427] RBP: ffff88001e573e08 R08: 0000000000000001 R09: 0000000000000000
[ 17.581352] R10: 000ffffffffff000 R11: 0000000000000000 R12: 0000000003200000
[ 17.582992] R13: 0000000000000163 R14: 0000000000000063 R15: 0000000000000001
[ 17.584241] FS: 0000000000000000(0000) GS:ffffffff82e99000(0000) knlGS:0000000000000000
[ 17.586073] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 17.587416] CR2: 0000000000000000 CR3: 0000000002e74000 CR4: 00000000000006b0
[ 17.589080] Call Trace:
[ 17.589676] ? vsyscall_gtod_data+0xf80/0xf80
[ 17.590704] ? vsyscall_gtod_data+0xf80/0xf80
[ 17.591728] ? mutex_unlock+0x12/0x20
[ 17.592594] ? vsyscall_gtod_data+0xf80/0xf80
[ 17.593623] change_page_attr_set_clr+0x216/0x5d0
[ 17.594722] ? vsyscall_gtod_data+0xf80/0xf80
[ 17.595749] set_memory_nx+0x3a/0x40
[ 17.596599] ? vsyscall_gtod_data+0xf80/0xf80
[ 17.597625] free_init_pages+0x98/0xe0
[ 17.598511] ? rest_init+0xb0/0xb0
[ 17.599320] free_initmem+0x28/0x30
[ 17.600148] kernel_init+0x22/0x100
[ 17.600977] ret_from_fork+0x3a/0x50
[ 17.601824] Code: 1e 02 01 e8 f9 e6 13 00 48 8b 95 58 ff ff ff 48 8b 0d 23 dd 34 02 4c 89 ee 48 c7 c7 18 28 aa 82 48 f7 d2 4c 21 ea e8 16 e4 06 00 <0f> 0b b9 01 00 00 00 31 d2 be 01 00 00 00 48 c7 c7 80 8b 26 83
[ 17.606341] ---[ end trace 16136a0c17150c2b ]---
[ 17.616310] Freeing unused kernel memory: 1548K
# HH:MM RESULT GOOD BAD GOOD_BUT_DIRTY DIRTY_NOT_BAD
git bisect start a9f81d026491b1dc0f64e4dad849a0b2ea0f03d5 0adb32858b0bddf4ada5f364a84ed60b196dbcda --
git bisect bad 89db5e5f1ed291b114171b5d81ee941e1eb70445 # 04:42 B 0 4 18 1 Merge 'linux-review/Xinming-Hu/mwifiex-parse-key-management-suite-from-RSN-IE/20180409-171140' into devel-spot-201804100130
git bisect bad f91328b04f19cf29e83ebbb512a1315489bfbbe9 # 04:58 B 0 9 24 2 Merge 'perf/perf/urgent' into devel-spot-201804100130
git bisect bad 033232e2c16a8c44d91aa8a43f0203ead03d0fac # 05:09 B 0 9 22 0 Merge 'linux-review/Sibi-Sankar/drm-msm-dsi-add-dsi-host-helper-functions-support/20180409-233706' into devel-spot-201804100130
git bisect bad c80c7a223772e856100903a6d8e15b9ef0596119 # 05:22 B 0 9 26 4 Merge 'tip/perf/urgent' into devel-spot-201804100130
git bisect good e4c1b9da9186f1de6a4f72818aa850e03fca1d1b # 05:34 G 11 0 0 0 Merge 'shli/for-next' into devel-spot-201804100130
git bisect good f913eccc9053b8b7c29ff0b9e5e4fe7fbb5b94e1 # 05:54 G 10 0 0 0 Merge 'tip/x86/urgent' into devel-spot-201804100130
git bisect bad 3fc99a3d6d548923163f10e75ba75e5a1cb762ec # 06:05 B 0 4 19 2 Merge 'tip/x86/pti' into devel-spot-201804100130
git bisect good 8a57f4849f4fa22ed18a941164a214083fc020a2 # 06:22 G 11 0 0 0 x86/mm: Introduce "default" kernel PTE mask
git bisect bad e71e836f463dd2cfb319ce88ae4a6e4f83904e6c # 07:08 B 0 8 23 2 x86/mm: Remove extra filtering in pageattr code
git bisect good 64c80759408f1c47d2414bfa79f80a4573a8d68d # 07:25 G 11 0 0 0 x86/mm: Do not auto-massage page protections
# first bad commit: [e71e836f463dd2cfb319ce88ae4a6e4f83904e6c] x86/mm: Remove extra filtering in pageattr code
git bisect good 64c80759408f1c47d2414bfa79f80a4573a8d68d # 07:27 G 31 0 0 0 x86/mm: Do not auto-massage page protections
# extra tests with debug options
git bisect bad e71e836f463dd2cfb319ce88ae4a6e4f83904e6c # 07:41 B 0 7 20 0 x86/mm: Remove extra filtering in pageattr code
# extra tests on HEAD of linux-devel/devel-spot-201804100130
git bisect bad a9f81d026491b1dc0f64e4dad849a0b2ea0f03d5 # 07:41 B 0 343 359 0 0day head guard for 'devel-spot-201804100130'
# extra tests on tree/branch tip/x86/pti
git bisect good 0564258fb2cfe6876738665314445bf391f450e2 # 08:01 G 10 0 0 0 x86/pti: Leave kernel text global for !PCID
# extra tests with first bad commit reverted
git bisect good eed15c0d8c2e4ba37eb663b885dee522dabb39dc # 08:12 G 11 0 0 0 Revert "x86/mm: Remove extra filtering in pageattr code"
# extra tests on tree/branch tip/master
git bisect good 87e1e2f51cc3159ba33f71b9b30ac04d0753227c # 08:29 G 11 0 0 0 Merge branch 'x86/pti'
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/lkp Intel Corporation
Download attachment "dmesg-quantal-vp-13:20180410070827:x86_64-randconfig-s3-04100201:4.16.0-02286-ge71e836:1.gz" of type "application/gzip" (23026 bytes)
View attachment "reproduce-quantal-vp-13:20180410070827:x86_64-randconfig-s3-04100201:4.16.0-02286-ge71e836:1" of type "text/plain" (909 bytes)
View attachment "config-4.16.0-02286-ge71e836" of type "text/plain" (112662 bytes)
Powered by blists - more mailing lists