linux-kernel - Re: [PATCH v2] qla2xxx: correctly shift host byte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1muyb3lmg.fsf@oracle.com>
Date:   Mon, 09 Apr 2018 21:17:59 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Johannes Thumshirn <jthumshirn@...e.de>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        Bart Van Assche <Bart.VanAssche@...disk.com>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
        Linux SCSI Mailinglist <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH v2] qla2xxx: correctly shift host byte


Johannes,

> The SCSI host byte has to be shifted by 16 not 6.
>
> As Bart pointed out this patch does not change any functionality
> because DID_OK == 0, but a wrong shift is irritating for the reviewer.

Applied to 4.17/scsi-fixes. Thank you!

-- 
Martin K. Petersen	Oracle Linux Engineering