linux-kernel - Re: [Xen-devel] [RFC, v2, 1/9] hyper_dmabuf: initial upload of hyper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05859c14-e4a9-db9e-bb4c-35aa26d04c23@arm.com>
Date:   Tue, 10 Apr 2018 11:47:42 +0100
From:   Julien Grall <julien.grall@....com>
To:     Oleksandr Andrushchenko <andr2000@...il.com>,
        Dongwon Kim <dongwon.kim@...el.com>,
        linux-kernel@...r.kernel.org, linaro-mm-sig@...ts.linaro.org,
        xen-devel@...ts.xenproject.org
Cc:     mateuszx.potrola@...el.com, dri-devel@...ts.freedesktop.org
Subject: Re: [Xen-devel] [RFC, v2, 1/9] hyper_dmabuf: initial upload of
 hyper_dmabuf drv core framework

Hi,

On 04/10/2018 09:53 AM, Oleksandr Andrushchenko wrote:
> On 02/14/2018 03:50 AM, Dongwon Kim wrote:
>> diff --git a/drivers/dma-buf/hyper_dmabuf/hyper_dmabuf_id.h 

[...]

>> +#ifndef __HYPER_DMABUF_ID_H__
>> +#define __HYPER_DMABUF_ID_H__
>> +
>> +#define HYPER_DMABUF_ID_CREATE(domid, cnt) \
>> +    ((((domid) & 0xFF) << 24) | ((cnt) & 0xFFFFFF))
> I would define hyper_dmabuf_id_t.id as a union or 2 separate
> fields to avoid his magic

I am not sure the union would be right here because the layout will 
differs between big and little endian. So does that value will be passed 
to other guest?

Cheers,

-- 
Julien Grall