linux-kernel - Re: [PATCH] tools: restore READ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180410105515.oma5rzzh5y3ghhkx@lakrids.cambridge.arm.com>
Date:   Tue, 10 Apr 2018 11:55:15 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     Arnaldo Carvalho de Melo <acme@...hat.com>
Cc:     linux-kernel@...r.kernel.org, lizhijian@...fujitsu.com,
        sandipan@...ux.vnet.ibm.com
Subject: Re: [PATCH] tools: restore READ_ONCE() C++ compatibility

On Mon, Apr 09, 2018 at 04:40:32PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Apr 09, 2018 at 06:10:41PM +0100, Mark Rutland escreveu:
> > Hi Arnaldo,
> > 
> > As Sandipan gave a Tested-by for this, are you happy to pick it up as a
> > fix for v4.17?
> > 
> > Or would you prefer that I resend this?
> 
> I forgot about this fix, but was exposed to it while processing
> Sandipan's patches for fixing up builtin clang support, so I ended up
> adding the following patch:
> 
> https://git.kernel.org/acme/c/ad0902e0c400
> 
> This sidesteps this issue by removing the sequence of includes that ends
> up including the compiler.h from a C++ file.
> 
> Now 'make LIBCLANGLLVM=1 -C tools/perf' works, but I'll look at the
> patch below, probably it will save some time in the future if we get to
> include compiler.h from C++ code again...
> 
> Take a look at my perf/urgent branch, that I just asked Ingo to pull.

Ah, that's great.

Sorry for the noise!

Mark.