linux-kernel - Re: [RFC PATCH] sdhci: arasan: Add runtime PM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b02c6970-f4f5-53af-2834-710ff3b7cbaa@xilinx.com>
Date:   Tue, 10 Apr 2018 14:06:14 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Adrian Hunter <adrian.hunter@...el.com>, <naranimanish@...il.com>,
        <michal.simek@...inx.com>, <ulf.hansson@...aro.org>,
        <linux-mmc@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
CC:     Manish Narani <mnarani@...inx.com>
Subject: Re: [RFC PATCH] sdhci: arasan: Add runtime PM support

Hi Adrian,

On 10.4.2018 13:42, Adrian Hunter wrote:
> On 29/03/18 08:48, naranimanish@...il.com wrote:
>> From: Manish Narani <mnarani@...inx.com>
>>
>> This patch adds runtime PM support in Arasan SD driver.
>>
>> Signed-off-by: Manish Narani <mnarani@...inx.com>
> 
> Just a couple of comments about style.
> 
>> ---
>>  drivers/mmc/host/sdhci-of-arasan.c | 83 +++++++++++++++++++++++++++++++++++++-
>>  1 file changed, 81 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
>> index c33a5f7..47196b5 100644
>> --- a/drivers/mmc/host/sdhci-of-arasan.c
>> +++ b/drivers/mmc/host/sdhci-of-arasan.c
>> @@ -23,6 +23,7 @@
>>  #include <linux/mfd/syscon.h>
>>  #include <linux/module.h>
>>  #include <linux/of_device.h>
>> +#include <linux/pm_runtime.h>
>>  #include <linux/phy/phy.h>
>>  #include <linux/regmap.h>
>>  #include <linux/of.h>
>> @@ -349,6 +350,75 @@ static const struct sdhci_pltfm_data sdhci_arasan_cqe_pdata = {
>>  			SDHCI_QUIRK2_CLOCK_DIV_ZERO_BROKEN,
>>  };
>>  
>> +#ifdef CONFIG_PM
>> +/**
>> + * sdhci_arasan_runtime_suspend - Suspend method for the driver
>> + * @dev:	Address of the device structure
>> + * Returns 0 on success and error value on error
>> + *
>> + * Put the device in a low power state.
>> + */
> 
> Kernel style is not to put kerneldoc on callback functions.

I have never read that there are some sort of list of functions which
shouldn't be covered by kernel-doc.
What's the problem with using kerneldoc format here? Maybe I am not
getting your comments.

Thanks,
Michal