linux-kernel - Re: [RFC] mm, slab: reschedule cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <983c61d1-1444-db1f-65c1-3b519ac4d57b@suse.cz>
Date:   Tue, 10 Apr 2018 21:40:19 +0200
From:   Vlastimil Babka <vbabka@...e.cz>
To:     Christopher Lameter <cl@...ux.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        David Rientjes <rientjes@...gle.com>,
        Pekka Enberg <penberg@...nel.org>, Tejun Heo <tj@...nel.org>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        John Stultz <john.stultz@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Stephen Boyd <sboyd@...nel.org>
Subject: Re: [RFC] mm, slab: reschedule cache_reap() on the same CPU

On 04/10/2018 04:12 PM, Christopher Lameter wrote:
> On Tue, 10 Apr 2018, Vlastimil Babka wrote:
> 
>> cache_reap() is initially scheduled in start_cpu_timer() via
>> schedule_delayed_work_on(). But then the next iterations are scheduled via
>> schedule_delayed_work(), thus using WORK_CPU_UNBOUND.
> 
> That is a bug.. cache_reap must run on the same cpu since it deals with
> the per cpu queues of the current cpu. Scheduled_delayed_work() used to
> guarantee running on teh same cpu.

Did it? When did it stop? (which stable kernels should we backport to?)
So is my assumption correct that without specifying a CPU, the next work
might be processed on a different cpu than the current one, *and also*
be executed with a kthread/u* that can migrate to another cpu *in the
middle of the work*? Tejun?

>> This patch makes sure schedule_delayed_work_on() is used with the proper cpu
>> when scheduling the next iteration. The cpu is stored with delayed_work on a
>> new slab_reap_work_struct super-structure.
> 
> The current cpu is readily available via smp_processor_id(). Why a
> super structure?

Mostly for the WARN_ON_ONCE, and general paranoia.

>> @@ -4074,7 +4086,8 @@ static void cache_reap(struct work_struct *w)
>>  	next_reap_node();
>>  out:
>>  	/* Set up the next iteration */
>> -	schedule_delayed_work(work, round_jiffies_relative(REAPTIMEOUT_AC));
>> +	schedule_delayed_work_on(reap_work->cpu, work,
>> +					round_jiffies_relative(REAPTIMEOUT_AC));
> 
> schedule_delayed_work_on(smp_processor_id(), work, round_jiffies_relative(REAPTIMEOUT_AC));
> 
> instead all of the other changes?

If we can rely on that 100%, sure.