linux-kernel - Re: [PATCH] x86: fix pgprotval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5f6f0b92-9774-2dc8-c28b-4a9e3a9a211d@linux.intel.com>
Date:   Tue, 10 Apr 2018 13:00:25 -0700
From:   Dave Hansen <dave.hansen@...ux.intel.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, x86@...nel.org
Cc:     "H. Peter Anvin" <hpa@...or.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: fix pgprotval_t format string

On 04/10/2018 01:43 AM, Arnd Bergmann wrote:
> --- a/arch/x86/include/asm/pgtable.h
> +++ b/arch/x86/include/asm/pgtable.h
> @@ -533,11 +533,11 @@ static inline pgprotval_t check_pgprot(pgprot_t pgprot)
>  	/* mmdebug.h can not be included here because of dependencies */
>  #ifdef CONFIG_DEBUG_VM
>  	WARN_ONCE(pgprot_val(pgprot) != massaged_val,
> -		  "attempted to set unsupported pgprot: %016lx "
> -		  "bits: %016lx supported: %016lx\n",
> -		  pgprot_val(pgprot),
> -		  pgprot_val(pgprot) ^ massaged_val,
> -		  __supported_pte_mask);
> +		  "attempted to set unsupported pgprot: %016llx "
> +		  "bits: %016llx supported: %016llx\n",
> +		  (u64)pgprot_val(pgprot),
> +		  (u64)pgprot_val(pgprot) ^ massaged_val,
> +		  (u64)__supported_pte_mask);
>  #endif

Whoops, I just sent a similar patch.  I just used 'unsigned long long'
instead of u64.  I'm fine with this as well, and don't prefer one over
the other, so:

Acked-by: Dave Hansen <dave.hansen@...ux.intel.com>