linux-kernel - Re: [PATCH] hwmon: (scmi) handle absence of few types of sensors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180410201419.GA27759@roeck-us.net>
Date:   Tue, 10 Apr 2018 13:14:19 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Sudeep Holla <sudeep.holla@....com>
Cc:     linux-kernel@...r.kernel.org,
        Jim Quinlan <james.quinlan@...adcom.com>,
        linux-hwmon@...r.kernel.org
Subject: Re: [PATCH] hwmon: (scmi) handle absence of few types of sensors

On Fri, Apr 06, 2018 at 04:30:47PM +0100, Sudeep Holla wrote:
> Currently the loop checks for non-zero count of sensors for each type
> of sensors which is completely wrong. It also results in aborting the
> registration of sensors if one or more types of sensors are completely
> not supported by the platform SCMI firmware.
> 
> This patch fixes the issue by continue to loop and skiping sensor types
> that are not present.
> 
> Fixes: b23688aefb8b ("hwmon: add support for sensors exported via ARM SCMI")
> Reported-by: Jim Quinlan <james.quinlan@...adcom.com>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: linux-hwmon@...r.kernel.org
> Signed-off-by: Sudeep Holla <sudeep.holla@....com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/scmi-hwmon.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c
> index 363bf56eb0f2..91976b6ca300 100644
> --- a/drivers/hwmon/scmi-hwmon.c
> +++ b/drivers/hwmon/scmi-hwmon.c
> @@ -170,7 +170,10 @@ static int scmi_hwmon_probe(struct scmi_device *sdev)
>  	scmi_chip_info.info = ptr_scmi_ci;
>  	chip_info = &scmi_chip_info;
>  
> -	for (type = 0; type < hwmon_max && nr_count[type]; type++) {
> +	for (type = 0; type < hwmon_max; type++) {
> +		if (!nr_count[type])
> +			continue;
> +
>  		scmi_hwmon_add_chan_info(scmi_hwmon_chan, dev, nr_count[type],
>  					 type, hwmon_attributes[type]);
>  		*ptr_scmi_ci++ = scmi_hwmon_chan++;
> -- 
> 2.7.4
>