linux-kernel - Re: [PATCH] perf session: Fix undeclared 'oe'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <82d8f577-bbbb-0419-bf41-057522eb3f30@linux.ibm.com>
Date:   Wed, 11 Apr 2018 17:21:29 -0300
From:   Murilo Opsfelder Araújo <muriloo@...ux.ibm.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        David Carrillo-Cisneros <davidcc@...gle.com>,
        He Kuang <hekuang@...wei.com>, Ingo Molnar <mingo@...hat.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Paul Mackerras <paulus@...ba.org>,
        Paul Turner <pjt@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Sasha Levin <alexander.levin@...rosoft.com>,
        Simon Que <sque@...omium.org>,
        Stephane Eranian <eranian@...gle.com>,
        Wang Nan <wangnan0@...wei.com>
Subject: Re: [PATCH] perf session: Fix undeclared 'oe'

On 04/11/2018 04:33 PM, Greg Kroah-Hartman wrote:
> On Wed, Apr 11, 2018 at 03:41:35PM -0300, Murilo Opsfelder Araujo wrote:
>> Using linux-3.18.y branch, perf build fails with the following:
>>
>>     $ make -s -j16 -C tools/perf V=1 WERROR=0 NO_LIBUNWIND=1 HAVE_CPLUS_DEMANGLE=1 NO_GTK2=1 NO_LIBNUMA=1 NO_STRLCPY=1 NO_BIONIC=1 prefix=/usr DESTDIR=/tmp/builddir/build all
>>     [...]
>>     util/session.c: In function ‘__perf_session__process_pipe_events’:
>>     util/session.c:1093:36: error: ‘oe’ undeclared (first use in this function)
>>       ordered_events__set_copy_on_queue(oe, true);
>>                                         ^
>>     util/session.c:1093:36: note: each undeclared identifier is reported only once for each function it appears in
>>
>> This patch fixes it for linux-3.18.y branch.
> 
> Why is this failing now?  Has it always been broken?  Is there an
> upstream patch that fixed this instead?
> 

Hi, Greg.

We've caught this build issue this week. I'm not sure since when it's
failing.

The upstream patch that fixes this is:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fa713a4eb9cebe5dec71b1bd11429603e17d841d

commit fa713a4eb9cebe5dec71b1bd11429603e17d841d
Author: Arnaldo Carvalho de Melo <acme@...hat.com>
Date:   Tue Mar 3 11:48:12 2015 -0300

    perf ordered_events: Untangle from perf_session

But it doesn't apply straightforwardly.  At
fa713a4eb9cebe5dec71b1bd11429603e17d841d, perf API and perf_evlist
struct are slightly different from linux-3.18.y.

A list of upstream patches for a clean backport (I think) would be:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=54245fdc357613633954bfd38cffb71cb9def067

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=75be989a7a18e9666efd92b846ee48bed79e8086

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=313e53b08e99b1dacf9ea2b0fbe97890db1ea95f

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9fa8727aa4d98d35ca50ef9cd8a50c6468af921d

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fa713a4eb9cebe5dec71b1bd11429603e17d841d

Do you prefer all above patches backported to linux-3.18.y or just the
one-line fix I sent?

>> Fixes: 95b33b99cdd6 ("perf inject: Copy events when reordering events in pipe mode")
> 
> Was this just a bad backport?

Some patches were left behind, I guess.

> 
> thanks,
> 
> greg k-h
> 

Cheers
Murilo