linux-kernel - Re: [PATCH v3] isofs compress: Remove VLA usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180411063946.GP30522@ZenIV.linux.org.uk>
Date:   Wed, 11 Apr 2018 07:39:46 +0100
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Joe Perches <joe@...ches.com>
Cc:     Kees Cook <keescook@...omium.org>,
        Kyle Spiers <ksspiers@...gle.com>, Jan Kara <jack@...e.cz>,
        Arnd Bergmann <arnd@...db.de>,
        David Howells <dhowells@...hat.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] isofs compress: Remove VLA usage

On Tue, Apr 10, 2018 at 11:15:28PM -0700, Joe Perches wrote:
> On Tue, 2018-04-10 at 17:51 -0700, Kees Cook wrote:
> > On Tue, Apr 10, 2018 at 5:33 PM, Al Viro <viro@...iv.linux.org.uk> wrote:
> > > On Tue, Apr 10, 2018 at 04:45:32PM -0700, Kyle Spiers wrote:
> > > > As part of the effort to remove VLAs from the kernel[1], this changes
> > > > the allocation of the bhs and pages arrays from being on the stack to being
> > > > kcalloc()ed. This also allows for the removal of the explicit zeroing
> > > > of bhs.
> > > > 
> > > > https://lkml.org/lkml/2018/3/7/621
> > > 
> > > Do you even bother reading the feedback given to such patches?  I'm just
> > > curious,
> > 
> > He made a tool mistake (sent v2 again) -- please see v4.
> 
> No worries but Kyle didn't just mistakenly resend v2.
> It was a v3 with a different below the dashes changelog.
> 
> Kyle, it would be good if next time you were to add a
> listing of changes in each revision below the dashes.

Shit happens...

Al, fully expecting to discover having made something spectacularly bonehead
2 minutes after sending a patch out - happens often enough.