linux-kernel - Re: [PATCH v3] isofs compress: Remove VLA usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jJBqiXZzvRaoXRVuxFckaFJq+LfM227t2uXF3vhwE7WPg@mail.gmail.com>
Date:   Tue, 10 Apr 2018 17:51:48 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     Kyle Spiers <ksspiers@...gle.com>, Jan Kara <jack@...e.cz>,
        Arnd Bergmann <arnd@...db.de>,
        David Howells <dhowells@...hat.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        Joe Perches <joe@...ches.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] isofs compress: Remove VLA usage

On Tue, Apr 10, 2018 at 5:33 PM, Al Viro <viro@...iv.linux.org.uk> wrote:
> On Tue, Apr 10, 2018 at 04:45:32PM -0700, Kyle Spiers wrote:
>> As part of the effort to remove VLAs from the kernel[1], this changes
>> the allocation of the bhs and pages arrays from being on the stack to being
>> kcalloc()ed. This also allows for the removal of the explicit zeroing
>> of bhs.
>>
>> https://lkml.org/lkml/2018/3/7/621
>
> Do you even bother reading the feedback given to such patches?  I'm just
> curious,

He made a tool mistake (sent v2 again) -- please see v4.

-Kees

-- 
Kees Cook
Pixel Security