linux-kernel - Re: [PATCH][v2] tools/power turbostat: if --max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1523438944.2753.207.camel@gmail.com>
Date:   Wed, 11 Apr 2018 12:29:04 +0300
From:   Artem Bityutskiy <dedekind1@...il.com>
To:     Yu Chen <yu.c.chen@...el.com>, Len Brown <lenb@...nel.org>
Cc:     "Rafael J . Wysocki" <rjw@...ysocki.net>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][v2] tools/power turbostat: if --max_loop, print for
 specific time of loops

On Tue, 2018-04-10 at 22:51 +0800, Yu Chen wrote:
> +		case 't':
> +			{
> +				int loops = strtod(optarg, NULL);
> +
> +				if (loops <= 0) {
> +					fprintf(outf, "loops %d should be positive number\n",
> +						iterations);
> +					exit(2);
> +				}
> +				iterations = loops;
> +			}

What is the point of the additional {} scope and the 'loops' variable
in it? You could use the 'iterations' variable directly and simplify
the code.

Artem.