linux-kernel - Re: [PATCH v4] sparse: add -Wpointer-arith flag to toggle sizeof(void) warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180411102007.i6nkdh6pff5ycmu6@ltop.local>
Date:   Wed, 11 Apr 2018 12:20:08 +0200
From:   Luc Van Oostenryck <luc.vanoostenryck@...il.com>
To:     Joey Pabalinas <joeypabalinas@...il.com>
Cc:     linux-sparse@...r.kernel.org, Kees Cook <keescook@...omium.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Martin Uecker <Martin.Uecker@....uni-goettingen.de>,
        Al Viro <viro@...IV.linux.org.uk>,
        Christopher Li <sparse@...isli.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] sparse: add -Wpointer-arith flag to toggle
 sizeof(void) warnings

On Tue, Apr 10, 2018 at 12:46:24PM -1000, Joey Pabalinas wrote:
> Recent changes to the min()/max() macros in include/linux/kernel.h
> have added a lot of noise when compiling the kernel with Sparse checking
> enabled. This mostly is due to the *huge* increase in the number of
> sizeof(void) warnings, a larger number of which can safely be ignored.
> 
> Add the -Wpointer-arith flag to enable/disable these warnings (along
> with the warning when applying sizeof to function types as well as
> warning about pointer arithmetic on these types exactly like the
> GCC -Wpointer-arith flag) on demand; the warning itself has been disabled
> by default to reduce the large influx of noise which was inadvertently
> added by commit 3c8ba0d61d04ced9f8 (kernel.h: Retain constant expression
> output for max()/min()).
> 
> Update the manpage to document the new flag and add a validation case
> for sizeof(void).
> 
> CC: Kees Cook <keescook@...omium.org>
> CC: Linus Torvalds <torvalds@...ux-foundation.org>
> CC: Martin Uecker <Martin.Uecker@....uni-goettingen.de>
> CC: Al Viro <viro@...IV.linux.org.uk>
> CC: Christopher Li <sparse@...isli.org>
> CC: Joey Pabalinas <joeypabalinas@...il.com>
> CC: Luc Van Oostenryck <luc.vanoostenryck@...il.com>
> Signed-off-by: Joey Pabalinas <joeypabalinas@...il.com>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@...il.com>

Thanks,
Acked-by: Luc Van Oostenryck <luc.vanoostenryck@...il.com>