linux-kernel - Q: Can we get rid of __copy_siginfo_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <87d0z6ttxe.fsf@xmission.com>
Date:   Tue, 10 Apr 2018 20:26:21 -0500
From:   ebiederm@...ssion.com (Eric W. Biederman)
To:     Andy Lutomirski <luto@...nel.org>
Cc:     X86 ML <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Q: Can we get rid of __copy_siginfo_to_user32?

Andy,

I am looking at copy_siginfo_to_user32 and find it very unfortunate
that x86 with _sigchld_x32 needs to be the odd man out.  I am looking
at ways to simplify the special case.

The core of the special case comes from:
exit_to_usermode_loop
  do_signal
    handle_signal
       setup_rt_frame

In setup_rt_frame the code looks at ksig to see which kind of signal
frame should be written for the signal.

This leads to the one case in the kernel where copy_siginfo_to_user32
does not use is_ia32_syscall() or is_x32_syscall() to see which kind of
signal frame it needs to create.

Andy, since you have been all over the entry point code in recent years
do you know if we allow tasks that can do both ia32 and x86_64 system
calls?  That seems to be what we the testing of ksig to see which kind
of signal frame to setup is all about.

If we don't allow mixed abi's on x86_64 then can I see if I have a ia32
task in setup_rt_frame by just calling is_ia32_syscall()?

If we do allow mixed abi's do you know if it would be safe to
temporarily play with orig_ax or current_thread_info()->status?

My goal is to write two wrappers: copy_siginfo_to_user32_ia32, and
copy_siginfo_to_user32_x32 around the ordinary copy_siginfo_to_user32.
With only a runtime test to see which ABI we need to implement.

Aka change:
> 	case SIL_CHLD:
> 		to->si_pid    = from->si_pid;
> 		to->si_uid    = from->si_uid;
> 		to->si_status = from->si_status;
> #ifdef CONFIG_X86_X32_ABI
> 		if (x32_ABI) {
> 			to->_sifields._sigchld_x32._utime = from->si_utime;
> 			to->_sifields._sigchld_x32._stime = from->si_stime;
> 		} else
> #endif
> 		{
> 			to->si_utime = from->si_utime;
> 			to->si_stime = from->si_stime;
> 		}
> 		break;
to something like:                
> 	case SIL_CHLD:
> 		to->si_pid    = from->si_pid;
> 		to->si_uid    = from->si_uid;
> 		to->si_status = from->si_status;
> #ifdef CONFIG_X86_X32_ABI
> 		if (!is_ia32_syscall()) {
> 			to->_sifields._sigchld_x32._utime = from->si_utime;
> 			to->_sifields._sigchld_x32._stime = from->si_stime;
> 		} else
> #endif
> 		{
> 			to->si_utime = from->si_utime;
> 			to->si_stime = from->si_stime;
> 		}
> 		break;

I just don't understand the introdcacies of the ia32 and x32 emulation
to really guess which test I need to substitute in there.  So any help
or ideas would really be appreciated.

Eric