linux-kernel - Re: [PATCH] KVM: X86: fix incorrect reference of trace_kvm_pi_irte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <63adcbc6-95a4-48f4-e90d-34d3722b40ea@redhat.com>
Date:   Wed, 11 Apr 2018 13:34:55 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     hu huajun <huhuajun@...ux.alibaba.com>, joro@...tes.org,
        rkrcmar@...hat.com, tglx@...utronix.de, mingo@...hat.com,
        hpa@...or.com
Cc:     x86@...nel.org, kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: X86: fix incorrect reference of
 trace_kvm_pi_irte_update

On 11/04/2018 09:16, hu huajun wrote:
> In arch/x86/kvm/trace.h, this function is declared as host_irq the
> first input, and vcpu_id the second, instead of otherwise.
> 
> Signed-off-by: hu huajun <huhuajun@...ux.alibaba.com>
> ---
>  arch/x86/kvm/svm.c | 5 ++---
>  arch/x86/kvm/vmx.c | 2 +-
>  2 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> index be9c839..f4e9fb4 100644
> --- a/arch/x86/kvm/svm.c
> +++ b/arch/x86/kvm/svm.c
> @@ -5118,9 +5118,8 @@ static int svm_update_pi_irte(struct kvm *kvm, unsigned int host_irq,
>  		}
>  
>  		if (!ret && svm) {
> -			trace_kvm_pi_irte_update(svm->vcpu.vcpu_id,
> -						 host_irq, e->gsi,
> -						 vcpu_info.vector,
> +			trace_kvm_pi_irte_update(host_irq, svm->vcpu.vcpu_id,
> +						 e->gsi, vcpu_info.vector,
>  						 vcpu_info.pi_desc_addr, set);
>  		}
>  
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index f0fd50b..86fd775 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -12204,7 +12204,7 @@ static int vmx_update_pi_irte(struct kvm *kvm, unsigned int host_irq,
>  		vcpu_info.pi_desc_addr = __pa(vcpu_to_pi_desc(vcpu));
>  		vcpu_info.vector = irq.vector;
>  
> -		trace_kvm_pi_irte_update(vcpu->vcpu_id, host_irq, e->gsi,
> +		trace_kvm_pi_irte_update(host_irq, vcpu->vcpu_id, e->gsi,
>  				vcpu_info.vector, vcpu_info.pi_desc_addr, set);
>  
>  		if (set)
> 

Applied, thanks!

Paolo