linux-kernel - Re: [PATCH] tty: ipwireless: Replace GFP_ATOMIC with GFP_KERNEL in ipwireless_network

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180411121103.GA2394@kroah.com>
Date:   Wed, 11 Apr 2018 14:11:03 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     dsterba@...e.cz, Jia-Ju Bai <baijiaju1990@...il.com>,
        davem@...emloft.net, johannes.berg@...el.com, jikos@...nel.org,
        stephen@...workplumber.org, Jiri Slaby <JSlaby@...e.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: ipwireless: Replace GFP_ATOMIC with GFP_KERNEL in
 ipwireless_network_create

On Wed, Apr 11, 2018 at 01:09:45PM +0200, David Sterba wrote:
> On Tue, Apr 10, 2018 at 04:31:46PM +0800, Jia-Ju Bai wrote:
> > ipwireless_network_create() is never called in atomic context.
> > 
> > The call chain ending up at ipwireless_network_create() is:
> > [1] ipwireless_network_create() <- config_ipwireless() <- 
> > 	ipwireless_attach()
> > ipwireless_attach() is only set as ".probe" in struct pcmcia_driver.
> > 
> > Despite never getting called from atomic context,
> > ipwireless_network_create() calls kzalloc() with GFP_ATOMIC,
> > which does not sleep for allocation.
> > GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
> > which can sleep and improve the possibility of sucessful allocation.
> > 
> > This is found by a static analysis tool named DCNS written by myself.
> > And I also manually check it.
> > 
> > Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com>
> 
> Reviewed-by: David Sterba <dsterba@...e.com>
> 
> We don't have any other patches queued for this driver so it would be
> best if this patch goes via net or Greg's tree.

I can take it, after 4.17-rc1 is out, thanks!

greg k-h