linux-kernel - Re: [PATCH] lan78xx: Correctly indicate invalid OTP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180411.103127.1511048337167278763.davem@davemloft.net>
Date:   Wed, 11 Apr 2018 10:31:27 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     phil@...pberrypi.org
Cc:     woojung.huh@...rochip.com, UNGLinuxDriver@...rochip.com,
        netdev@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lan78xx: Correctly indicate invalid OTP

From: Phil Elwell <phil@...pberrypi.org>
Date: Wed, 11 Apr 2018 10:59:17 +0100

> lan78xx_read_otp tries to return -EINVAL in the event of invalid OTP
> content, but the value gets overwritten before it is returned and the
> read goes ahead anyway. Make the read conditional as it should be
> and preserve the error code.
> 
> Signed-off-by: Phil Elwell <phil@...pberrypi.org>

Applied with appropriate Fixes: tag added, and queud up for -stable.

Thanks.