linux-kernel - Re: [PATCH] net: samsung: sxgbe: Replace mdelay with usleep_range in sxgbe_sw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201804112347.pxXFMDit%fengguang.wu@intel.com>
Date:   Wed, 11 Apr 2018 23:52:44 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Jia-Ju Bai <baijiaju1990@...il.com>
Cc:     kbuild-all@...org, bh74.an@...sung.com, ks.giri@...sung.com,
        vipul.pandya@...sung.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Jia-Ju Bai <baijiaju1990@...il.com>
Subject: Re: [PATCH] net: samsung: sxgbe: Replace mdelay with usleep_range in
 sxgbe_sw_reset

Hi Jia-Ju,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]
[also build test ERROR on v4.16 next-20180411]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jia-Ju-Bai/net-samsung-sxgbe-Replace-mdelay-with-usleep_range-in-sxgbe_sw_reset/20180411-225900
config: i386-randconfig-s1-201814 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/net//ethernet/samsung/sxgbe/sxgbe_main.c: In function 'sxgbe_sw_reset':
>> drivers/net//ethernet/samsung/sxgbe/sxgbe_main.c:2039:3: error: implicit declaration of function 'usleep' [-Werror=implicit-function-declaration]
      usleep(10000, 11000);
      ^~~~~~
   cc1: some warnings being treated as errors

vim +/usleep +2039 drivers/net//ethernet/samsung/sxgbe/sxgbe_main.c

  2029	
  2030	static int sxgbe_sw_reset(void __iomem *addr)
  2031	{
  2032		int retry_count = 10;
  2033	
  2034		writel(SXGBE_DMA_SOFT_RESET, addr + SXGBE_DMA_MODE_REG);
  2035		while (retry_count--) {
  2036			if (!(readl(addr + SXGBE_DMA_MODE_REG) &
  2037			      SXGBE_DMA_SOFT_RESET))
  2038				break;
> 2039			usleep(10000, 11000);
  2040		}
  2041	
  2042		if (retry_count < 0)
  2043			return -EBUSY;
  2044	
  2045		return 0;
  2046	}
  2047	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (24019 bytes)