linux-kernel - Re: clk: bulk: silently error out on EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9addb928-cec2-fda6-699e-489aa4518c64@rock-chips.com>
Date:   Wed, 11 Apr 2018 10:54:58 +0800
From:   Shawn Lin <shawn.lin@...k-chips.com>
To:     Jerome Brunet <jbrunet@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Michael Turquette <mturquette@...libre.com>
Cc:     shawn.lin@...k-chips.com, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: clk: bulk: silently error out on EPROBE_DEFER

Hi Jerome,

On 2018/4/9 22:13, Jerome Brunet wrote:
> In clk_bulk_get(), if we fail to get the clock due to probe deferal, we
> shouldn't print an error message. Just be silent in this case.
> 

I saw a confusing clk get failure log occasionally, but didn't pay
much attention to it as the driver finally probed fine. But probably it
came from clk_bulk_get,

Reviewed-by: Shawn Lin <shawn.lin@...k-chips.com>

> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>
> ---
>   drivers/clk/clk-bulk.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/clk-bulk.c b/drivers/clk/clk-bulk.c
> index 4c10456f8a32..6904ed6da504 100644
> --- a/drivers/clk/clk-bulk.c
> +++ b/drivers/clk/clk-bulk.c
> @@ -42,8 +42,9 @@ int __must_check clk_bulk_get(struct device *dev, int num_clks,
>   		clks[i].clk = clk_get(dev, clks[i].id);
>   		if (IS_ERR(clks[i].clk)) {
>   			ret = PTR_ERR(clks[i].clk);
> -			dev_err(dev, "Failed to get clk '%s': %d\n",
> -				clks[i].id, ret);
> +			if (ret != -EPROBE_DEFER)
> +				dev_err(dev, "Failed to get clk '%s': %d\n",
> +					clks[i].id, ret);
>   			clks[i].clk = NULL;
>   			goto err;
>   		}
>