linux-kernel - RE: [PATCH] block: ratelimite pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Apr 2018 17:07:30 +0000
From:   "Elliott, Robert (Persistent Memory)" <elliott@....com>
To:     Jack Wang <jinpu.wang@...fitbricks.com>,
        "axboe@...nel.dk" <axboe@...nel.dk>
CC:     "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] block: ratelimite pr_err on IO path

> -----Original Message-----
> From: linux-kernel-owner@...r.kernel.org [mailto:linux-kernel-
> owner@...r.kernel.org] On Behalf Of Jack Wang
> Sent: Wednesday, April 11, 2018 8:21 AM
> Subject: [PATCH] block: ratelimite pr_err on IO path
> 
> From: Jack Wang <jinpu.wang@...fitbricks.com>
...
> -				pr_err("%s: ref tag error at location %llu " \
> -				       "(rcvd %u)\n", iter->disk_name,
> -				       (unsigned long long)
> -				       iter->seed, be32_to_cpu(pi->ref_tag));
> +				pr_err_ratelimited("%s: ref tag error at "
> +						   "location %llu (rcvd %u)\n",

Per process/coding-style.rst, you should keep a string like that on
one line even if that exceeds 80 columns:

  Statements longer than 80 columns will be broken into sensible chunks, unless
  exceeding 80 columns significantly increases readability and does not hide
  information. ... However, never break user-visible strings such as
  printk messages, because that breaks the ability to grep for them.