linux-kernel - Re: [PATCH] staging: Android: Add 'vsoc' driver for cuttlefish.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20180411183216.hn7l5djgrzezomtr@mwanda>
Date:   Wed, 11 Apr 2018 21:32:16 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Greg Hartman <ghartman@...gle.com>
Cc:     Alistair Strachan <astrachan@...gle.com>,
        linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
        arve@...roid.com, tkjos@...roid.com, maco@...roid.com,
        devel@...verdev.osuosl.org, kernel-team@...roid.com
Subject: Re: [PATCH] staging: Android: Add 'vsoc' driver for cuttlefish.

On Wed, Apr 11, 2018 at 10:49:47AM -0700, Greg Hartman wrote:
> > +     /* Ensure that the offset is within shared memory */
> > +     if (((uint64_t)arg->offset) + region_p->region_begin_offset +
> > +         sizeof(uint32_t) > region_p->region_end_offset)
> 
> I'm not certain if I understand the overflow.
> 
> arg->offset, region_begin_offset, and region_end_offset are all uint32.
> 

Ah...  You're right.  I didn't read carefully.  Sorry for the noise.

regards,
dan carpenter