lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <87fu42l92b.fsf@concordia.ellerman.id.au> Date: Wed, 11 Apr 2018 13:24:12 +1000 From: Michael Ellerman <mpe@...erman.id.au> To: Shuah Khan <shuahkh@....samsung.com>, Christian Brauner <christian.brauner@...onical.com> Cc: linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org, viro@...iv.linux.org.uk, ebiederm@...ssion.com, torvalds@...ux-foundation.org, gregkh@...uxfoundation.org, Shuah Khan <shuahkh@....samsung.com>, Shuah Khan <shuah@...nel.org> Subject: Re: [PATCH] selftests/filesystems: Don't run dnotify_test by default Shuah Khan <shuahkh@....samsung.com> writes: > On 04/10/2018 03:45 AM, Christian Brauner wrote: >> On Tue, Apr 10, 2018 at 04:20:53PM +1000, Michael Ellerman wrote: >>> In commit ce290a19609d ("selftests: add devpts selftests"), the >>> filesystems directory was added to the top-level selftests Makefile. >>> >>> That had the effect of causing the existing dnotify_test in the >>> filesystems directory to now be run as part of the default selftests >>> test-run. Unfortunately dnotify_test is actually an infinite loop. >>> >>> Fix it by moving dnotify_test to TEST_GEN_PROGS_EXTENDED, which says >>> that it's a generated file (ie. built) but should not be run as part >>> of the default test suite run (it's an "extendend" test). > > Typo - I can fix it when I apply it. Oops, thanks. >>> While we're here cleanup a few other things, devpts_pts should be in >>> TEST_GEN_PROGS to indicate that it's built, and with the above two >>> changes we no longer need a custom all or clean rule. >>> >>> Fixes: ce290a19609d ("selftests: add devpts selftests") >>> Signed-off-by: Michael Ellerman <mpe@...erman.id.au> >> >> I'm not sure if I should've made it to be built given that it wasn't >> before but it probably doesn't hurt. It's either that or remove it I >> guess. > > This way the test gets built and gets included in the installed tests. > This way somebody can run it by itself. >> >> Acked-by: Christian brauner <christian.brauner@...ntu.com> > > Thanks Michael. I will get this into 4.17-rc2 or rc3. Thanks. cheers
Powered by blists - more mailing lists