linux-kernel - Re: [PATCH 4.9 022/310] pidns: disable pid allocation if pid_ns_prepare_proc() is failed in alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180412082526.GB6054@kroah.com>
Date:   Thu, 12 Apr 2018 10:25:26 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "Eric W. Biederman" <ebiederm@...ssion.com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Kirill Tkhai <ktkhai@...tuozzo.com>,
        Cyrill Gorcunov <gorcunov@...nvz.org>,
        Andrei Vagin <avagin@...tuozzo.com>,
        Andreas Gruenbacher <agruenba@...hat.com>,
        Kees Cook <keescook@...omium.org>,
        Michael Kerrisk <mtk.manpages@...glemail.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        Oleg Nesterov <oleg@...hat.com>,
        Paul Moore <paul@...l-moore.com>,
        Andy Lutomirski <luto@...capital.net>,
        Ingo Molnar <mingo@...nel.org>,
        Serge Hallyn <serge@...lyn.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Sasha Levin <alexander.levin@...rosoft.com>
Subject: Re: [PATCH 4.9 022/310] pidns: disable pid allocation if
 pid_ns_prepare_proc() is failed in alloc_pid()

On Wed, Apr 11, 2018 at 02:27:19PM -0500, Eric W. Biederman wrote:
> Greg Kroah-Hartman <gregkh@...uxfoundation.org> writes:
> 
> > 4.9-stable review patch.  If anyone has any objections, please let me
> > know.
> 
> No objections but if you are grabbing that one please check if you
> have it's follow on fix.
> 
> c0ee554906c3 ("pid: Handle failure to allocate the first pid in a pid namespace")
> 
> There were a few cases not handled but the fix below, that made a more
> comprehensive fix desirable.

Ok, but it looks like that commit needs to also go into 4.14.y as well,
as the original patch here, 8896c23d2ef8 ("pidns: disable pid allocation
if pid_ns_prepare_proc() is failed in alloc_pid()") showed up in 4.12.

Is that ok?

thanks,

greg k-h