linux-kernel - Re: [PATCH] drm/vc4: Fix leak of the file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180412111446.742450f0@bbrezillon>
Date:   Thu, 12 Apr 2018 11:14:46 +0200
From:   Boris Brezillon <boris.brezillon@...tlin.com>
To:     Eric Anholt <eric@...olt.net>
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/vc4: Fix leak of the file_priv that stored the
 perfmon.

On Mon,  9 Apr 2018 13:58:13 -0700
Eric Anholt <eric@...olt.net> wrote:

> Signed-off-by: Eric Anholt <eric@...olt.net>
> Fixes: 65101d8c9108 ("drm/vc4: Expose performance counters to userspace")

Reviewed-by: Boris Brezillon <boris.brezillon@...tlin.com>

> ---
>  drivers/gpu/drm/vc4/vc4_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
> index 94b99c90425a..7c95ed5c5cac 100644
> --- a/drivers/gpu/drm/vc4/vc4_drv.c
> +++ b/drivers/gpu/drm/vc4/vc4_drv.c
> @@ -130,6 +130,7 @@ static void vc4_close(struct drm_device *dev, struct drm_file *file)
>  	struct vc4_file *vc4file = file->driver_priv;
>  
>  	vc4_perfmon_close_file(vc4file);
> +	kfree(vc4file);
>  }
>  
>  static const struct vm_operations_struct vc4_vm_ops = {