linux-kernel - Re: [PATCH v7 3/9] pinctrl: actions: Add Actions S900 pinctrl driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94aceb15-63a5-44a3-d0bc-f56adebc27d5@suse.de>
Date:   Thu, 12 Apr 2018 14:10:28 +0200
From:   Andreas Färber <afaerber@...e.de>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>, liuwei@...ions-semi.com,
        mp-cs@...ions-semi.com, 96boards@...obotics.com,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Amit Kucheria <amit.kucheria@...aro.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        hzhang@...obotics.com, bdong@...obotics.com,
        Mani Sadhasivam <manivannanece23@...il.com>
Subject: Re: [PATCH v7 3/9] pinctrl: actions: Add Actions S900 pinctrl driver

Am 12.04.2018 um 11:04 schrieb Linus Walleij:
> On Wed, Apr 4, 2018 at 7:22 PM, Manivannan Sadhasivam
> <manivannan.sadhasivam@...aro.org> wrote:
> 
>> Add pinctrl driver for Actions Semi S900 SoC. The driver supports
>> pinctrl, pinmux and pinconf functionalities through a range of registers
>> common to both gpio driver and pinctrl driver.
>>
>> Pinmux functionality is available only for the pin groups while the
>> pinconf functionality is available for both pin groups and individual
>> pins.
>>
>> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> 
> Patch applied for v4.18
> 
> GOOD WORK!
> 
> We really need to get this in so that Andreas can work on S500
> patches with this as a base.

No, I refused to do that. If his patches get merged, Mani offered that
he will take care of rebasing/rewriting S500 part.

> 
> If any review comments still remain they can surely be addressed
> with incremental improvement patches.

My biggest problem was/is that Mani designed his structs totally
different from mine, with no explanation why or how they correlate.

Also I had protested against him defining fake pins for the drive
strength. Since I did not have time to review the newer patches yet,
please make sure that this is addressed _before_ merging. Changing the
binding after the fact is a problem!

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)