linux-kernel - Re: [PATCH 05/14] ARM: OMAP2: Add functions to save and restore powerdomain context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180412143717.GZ5700@atomide.com>
Date:   Thu, 12 Apr 2018 07:37:17 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Keerthy <j-keerthy@...com>
Cc:     linus.walleij@...aro.org, grygorii.strashko@...com,
        t-kristo@...com, Russ.Dill@...com, linux-omap@...r.kernel.org,
        linux-kernel@...r.kernel.org, ssantosh@...nel.org,
        haojian.zhuang@...aro.org, linux-arm-kernel@...ts.infradead.org,
        d-gerlach@...com
Subject: Re: [PATCH 05/14] ARM: OMAP2: Add functions to save and restore
 powerdomain context

* Keerthy <j-keerthy@...com> [180412 03:56]:
> From: Russ Dill <Russ.Dill@...com>
> --- a/arch/arm/mach-omap2/powerdomain.c
> +++ b/arch/arm/mach-omap2/powerdomain.c
> @@ -1199,3 +1199,63 @@ bool pwrdm_can_ever_lose_context(struct powerdomain *pwrdm)
>  
>  	return 0;
>  }
> +
> +/**
> + * pwrdm_save_context - save powerdomain registers
> + *
> + * Register state is going to be lost due to a suspend or hibernate
> + * event. Save the powerdomain registers.
> + */
> +static int pwrdm_save_context(struct powerdomain *pwrdm, void *unused)
> +{
> +	if (arch_pwrdm && arch_pwrdm->pwrdm_save_context)
> +		arch_pwrdm->pwrdm_save_context(pwrdm);
> +	return 0;
> +}
> +
> +/**
> + * pwrdm_save_context - restore powerdomain registers
> + *
> + * Restore powerdomain control registers after a suspend or resume
> + * event.
> + */
> +static int pwrdm_restore_context(struct powerdomain *pwrdm, void *unused)
> +{
> +	if (arch_pwrdm && arch_pwrdm->pwrdm_restore_context)
> +		arch_pwrdm->pwrdm_restore_context(pwrdm);
> +	return 0;
> +}

Here too we should use notifiers with the idea being that it allows making
powerdomains into a regular device driver eventually.

Regards,

Tony