linux-kernel - Re: [PATCH] regmap: debugfs: check pointer before access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180412144501.GE9929@sirena.org.uk>
Date:   Thu, 12 Apr 2018 15:45:01 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Peng Fan <peng.fan@....com>
Cc:     gregkh@...uxfoundation.org, linux-imx@....com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap: debugfs: check pointer before access

On Thu, Mar 29, 2018 at 08:21:54PM +0800, Peng Fan wrote:

> So add check here. When the driver pointer is NULL, return -EIO.

We should be providing a name if the file is there so rather than
returning an error we should provide something in the file so we should
either suppress creation of the file or provide a default string (the
latter is obviously easier and closer to what you have here).

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)